A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-30 03:27:44 -04:00
Code Issues Projects Releases Packages Wiki Activity

netlink: add netlink_dump_control structure for netlink_dump_start()

Browse source 
Davem considers that the argument list of this interface is getting
out of control. This patch tries to address this issue following
his proposal:

struct netlink_dump_control c = { .dump = dump, .done = done, ... };

netlink_dump_start(..., &c);

Suggested by David S. Miller.

Signed-off-by: Pablo Neira Ayuso <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
Pablo Neira Ayuso 2012-02-24 14:30:15 +00:00 • committed by David S. Miller
commit 80d326fab5
12 changed files with 87 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

11
net/netlink/af_netlink.c
View file

@ -1736,10 +1736,7 @@ errout_skb:
int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
const struct nlmsghdr *nlh,
int (*dump)(struct sk_buff *skb,
struct netlink_callback *),
int (*done)(struct netlink_callback *),
u16 min_dump_alloc)
struct netlink_dump_control *control)
{
struct netlink_callback *cb;
struct sock *sk;
@ -1750,10 +1747,10 @@ int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
if (cb == NULL)
return -ENOBUFS;
cb->dump = dump;
cb->done = done;
cb->dump = control->dump;
cb->done = control->done;
cb->nlh = nlh;
cb->min_dump_alloc = min_dump_alloc;
cb->min_dump_alloc = control->min_dump_alloc;
atomic_inc(&skb->users);
cb->skb = skb;

9
net/netlink/genetlink.c
View file

@ -563,8 +563,13 @@ static int genl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
return -EOPNOTSUPP;
genl_unlock();
err = netlink_dump_start(net->genl_sock, skb, nlh,
ops->dumpit, ops->done, 0);
{
struct netlink_dump_control c = {
.dump = ops->dumpit,
.done = ops->done,
};
err = netlink_dump_start(net->genl_sock, skb, nlh, &c);
}
genl_lock();
return err;
}