A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-07 20:33:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Do not free radio stats memory from wma

Browse source 
Currently driver frees the radio stats memory from wma
in error cases, there is a possibility that if hdd gets
time out for the stats request, it tries to free the radio
stats memory and at the same time if wma receives invalid
stats from fw in that case wma also tries to free the radio
stats memory which may lead to double free.

To aoid above issue, do not free the radio stats memory from
wma, in error cases hdd will free this memory after it gets
time out.

Change-Id: I6f6073a1a8e0be1b87efce288b7567e8fc8d69b0
CRs-Fixed: 3013842
This commit is contained in:
Ashish Kumar Dhanotiya 2021-08-13 19:17:00 +05:30 • committed by Madan Koyyalamudi
commit 87ba364a2c
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
core/wma/src/wma_utils.c
View file

@ -2191,7 +2191,6 @@ static int wma_unified_link_radio_stats_event_handler(void *handle,
* events may be spoofed. Drop all of them and report error.
*/
wma_err("Invalid following WMI_RADIO_LINK_STATS_EVENTID. Discarding this set");
wma_unified_radio_tx_mem_free(handle);
return -EINVAL;
}
@ -2242,10 +2241,8 @@ static int wma_unified_link_radio_stats_event_handler(void *handle,
channels_in_this_event = qdf_mem_malloc(
radio_stats->num_channels *
chan_stats_size);
if (!channels_in_this_event) {
wma_unified_radio_tx_mem_free(handle);
if (!channels_in_this_event)
return -ENOMEM;
}
chn_results =
(struct wifi_channel_stats *)&channels_in_this_event[0];
@ -2283,7 +2280,7 @@ static int wma_unified_link_radio_stats_event_handler(void *handle,
channels_in_this_event,
rs_results);
if (status) {
wma_unified_radio_tx_mem_free(handle);
wma_err("Failed to copy channel stats");
return status;
}
}