diff --git a/mm/hmm.c b/mm/hmm.c index 231de978d647..795faf021085 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -671,8 +671,8 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, pud = READ_ONCE(*pudp); if (pud_none(pud)) { - ret = hmm_vma_walk_hole(start, end, walk); - goto out_unlock; + spin_unlock(ptl); + return hmm_vma_walk_hole(start, end, walk); } if (pud_huge(pud) && pud_devmap(pud)) { @@ -681,8 +681,8 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, bool fault, write_fault; if (!pud_present(pud)) { - ret = hmm_vma_walk_hole(start, end, walk); - goto out_unlock; + spin_unlock(ptl); + return hmm_vma_walk_hole(start, end, walk); } i = (addr - range->start) >> PAGE_SHIFT; @@ -693,9 +693,9 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, hmm_range_need_fault(hmm_vma_walk, pfns, npages, cpu_flags, &fault, &write_fault); if (fault || write_fault) { - ret = hmm_vma_walk_hole_(addr, end, fault, - write_fault, walk); - goto out_unlock; + spin_unlock(ptl); + return hmm_vma_walk_hole_(addr, end, fault, write_fault, + walk); } pfn = pud_pfn(pud) + ((addr & ~PUD_MASK) >> PAGE_SHIFT);