From 4a646ab5f8a4c9de5a7a2450087dced6251b46f2 Mon Sep 17 00:00:00 2001 From: Mayank Rana Date: Wed, 15 Jul 2020 17:14:43 -0700 Subject: [PATCH] usb: gadget: qdss: Add error log with set_alt failure cases This change adds error logging to qdss_set_alt() to identify possible reason for seeing failure in some of cases. Change-Id: I6a0252ae7d29cc8be037b4fe5e9147e9835d3113 Signed-off-by: Mayank Rana --- drivers/usb/gadget/function/f_qdss.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/function/f_qdss.c b/drivers/usb/gadget/function/f_qdss.c index b4555735aebd..0e0b9c630883 100644 --- a/drivers/usb/gadget/function/f_qdss.c +++ b/drivers/usb/gadget/function/f_qdss.c @@ -686,14 +686,19 @@ static int qdss_set_alt(struct usb_function *f, unsigned int intf, /* Increment usage count on connect */ usb_gadget_autopm_get_async(qdss->gadget); - if (config_ep_by_speed(gadget, f, qdss->port.data)) { - ret = -EINVAL; + ret = config_ep_by_speed(gadget, f, qdss->port.data); + if (ret) { + pr_err("%s: failed config_ep_by_speed ret:%d\n", + __func__, ret); goto fail; } ret = usb_ep_enable(qdss->port.data); - if (ret) + if (ret) { + pr_err("%s: failed to enable ep ret:%d\n", + __func__, ret); goto fail; + } qdss->port.data->driver_data = qdss; qdss->data_enabled = 1; @@ -749,7 +754,7 @@ fail: /* Decrement usage count in case of failure */ usb_gadget_autopm_put_async(qdss->gadget); fail1: - pr_err("%s failed\n", __func__); + pr_err("%s failed ret:%d\n", __func__, ret); qdss_eps_disable(f); return ret; }