diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c21e4597a5bf..4370db214852 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6373,6 +6373,12 @@ sub process { "switch default: should use break\n" . $herectx); } +# check for return codes on error paths + if ($line =~ /\breturn\s+-\d+/) { + ERROR("NO_ERROR_CODE", + "illegal return value, please use an error code\n" . $herecurr); + } + # check for gcc specific __FUNCTION__ if ($line =~ /\b__FUNCTION__\b/) { if (WARN("USE_FUNC",