From 89e05224f00a217750ef10f9414cfe3e958b8af7 Mon Sep 17 00:00:00 2001 From: Yeshwanth Sriram Guntuka Date: Thu, 8 Jul 2021 16:28:00 +0530 Subject: [PATCH] qcacmn: Assert only when unmapped is true in rx_desc The existing assertions for unmapped variable in rx descriptor results in an undesired bug_on since the unmapped value is 0 for active descriptors. The fix is to modify this assertion so that bug_on will be triggered only if the unmapped value is 1 in rx desc. Change-Id: I03b27e0e42ce3c42b9fa148da9258063b0209b08 CRs-Fixed: 2985248 --- dp/wifi3.0/dp_rx.c | 2 +- dp/wifi3.0/dp_rx_err.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dp/wifi3.0/dp_rx.c b/dp/wifi3.0/dp_rx.c index a277ddf1016a..267de23d4322 100644 --- a/dp/wifi3.0/dp_rx.c +++ b/dp/wifi3.0/dp_rx.c @@ -2459,7 +2459,7 @@ more_data: ring_desc, rx_desc); if (QDF_IS_STATUS_ERROR(status)) { if (qdf_unlikely(rx_desc && rx_desc->nbuf)) { - qdf_assert_always(rx_desc->unmapped); + qdf_assert_always(!rx_desc->unmapped); dp_ipa_reo_ctx_buf_mapping_lock( soc, reo_ring_num); diff --git a/dp/wifi3.0/dp_rx_err.c b/dp/wifi3.0/dp_rx_err.c index 79523a0e6555..c891cb7dea12 100644 --- a/dp/wifi3.0/dp_rx_err.c +++ b/dp/wifi3.0/dp_rx_err.c @@ -1694,7 +1694,7 @@ static int dp_rx_err_handle_msdu_buf(struct dp_soc *soc, /* After this point the rx_desc and nbuf are valid */ dp_ipa_rx_buf_smmu_mapping_lock(soc); - qdf_assert_always(rx_desc->unmapped); + qdf_assert_always(!rx_desc->unmapped); dp_ipa_handle_rx_buf_smmu_mapping(soc, rx_desc->nbuf, RX_DATA_BUFFER_SIZE,