A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-30 03:27:44 -04:00
Code Issues Projects Releases Packages Wiki Activity

Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

Browse source 
hidp_send_message was changed to return non-zero values on success,
which some other bits did not expect. This caused spurious errors to be
propagated through the stack, breaking some drivers, such as hid-sony
for the Dualshock 4 in Bluetooth mode.

As pointed out by Dan Carpenter, hid-microsoft directly relied on that
assumption as well.

Fixes: 48d9cc9d85 ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes")

Signed-off-by: Dan Elkouby <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Reviewed-by: Jiri Kosina <[email protected]>
Signed-off-by: Marcel Holtmann <[email protected]>
This commit is contained in:
Dan Elkouby 2019-09-06 14:06:44 +03:00 • committed by Marcel Holtmann
commit 8bb3537095
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
net/bluetooth/hidp/core.c
View file

@ -267,7 +267,7 @@ static int hidp_get_raw_report(struct hid_device *hid,
set_bit(HIDP_WAITING_FOR_RETURN, &session->flags);
data[0] = report_number;
ret = hidp_send_ctrl_message(session, report_type, data, 1);
if (ret)
if (ret < 0)
goto err;
/* Wait for the return of the report. The returned report
@ -343,7 +343,7 @@ static int hidp_set_raw_report(struct hid_device *hid, unsigned char reportnum,
data[0] = reportnum;
set_bit(HIDP_WAITING_FOR_SEND_ACK, &session->flags);
ret = hidp_send_ctrl_message(session, report_type, data, count);
if (ret)
if (ret < 0)
goto err;
/* Wait for the ACK from the device. */