mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-30 03:27:44 -04:00
lib/kstrtox.c: smaller _parse_integer()
Set "overflow" bit upon encountering it instead of postponing to the end of the conversion. Somehow gcc unwedges itself and generates better code: $ ./scripts/bloat-o-meter ../vmlinux-000 ../obj/vmlinux _parse_integer 177 139 -38 Inspired by patch from Zhaoxiu Zeng. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Alexey Dobriyan <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
1204c77f9b
commit
8cfd56d479
1 changed files with 1 additions and 5 deletions
|
|
@ -48,11 +48,9 @@ unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long
|
|||
{
|
||||
unsigned long long res;
|
||||
unsigned int rv;
|
||||
int overflow;
|
||||
|
||||
res = 0;
|
||||
rv = 0;
|
||||
overflow = 0;
|
||||
while (*s) {
|
||||
unsigned int val;
|
||||
|
||||
|
|
@ -71,15 +69,13 @@ unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long
|
|||
*/
|
||||
if (unlikely(res & (~0ull << 60))) {
|
||||
if (res > div_u64(ULLONG_MAX - val, base))
|
||||
overflow = 1;
|
||||
rv |= KSTRTOX_OVERFLOW;
|
||||
}
|
||||
res = res * base + val;
|
||||
rv++;
|
||||
s++;
|
||||
}
|
||||
*p = res;
|
||||
if (overflow)
|
||||
rv |= KSTRTOX_OVERFLOW;
|
||||
return rv;
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue