A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-14 16:46:15 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Release the PDEV ref count by adding a new goto label

Browse source 
The function hdd_rx_mic_error_ind() is not releasing the pdev reference,
causing a pdev object manager leak for the WMI command WLAN_MLME_SB_ID.
To solve this, add a new goto label release_ref_and_return that releases
the pdev ref count before exiting the function.

Change-Id: Ic798cf5064403120058e01099bb846397e887951
CRs-Fixed: 2598665
This commit is contained in:
Alan Chen 2020-01-07 15:53:33 -08:00 • committed by nshrivas
commit 8dd79fb92c
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
core/hdd/src/wlan_hdd_main.c
View file

@ -7991,15 +7991,15 @@ hdd_rx_mic_error_ind(struct cdp_ctrl_objmgr_psoc *psoc, uint8_t pdev_id,
hdd_ctx = wiphy_priv(wiphy);
if (wlan_hdd_validate_context(hdd_ctx))
return;
goto release_ref_and_return;
adapter = hdd_get_adapter_by_vdev(hdd_ctx, mic_failure_info->vdev_id);
if (hdd_validate_adapter(adapter))
return;
goto release_ref_and_return;
hdd_mic_info = qdf_mem_malloc(sizeof(*hdd_mic_info));
if (!hdd_mic_info)
return;
goto release_ref_and_return;
qdf_copy_macaddr(&hdd_mic_info->ta_mac_addr,
&mic_failure_info->ta_mac_addr);
@ -8013,7 +8013,7 @@ hdd_rx_mic_error_ind(struct cdp_ctrl_objmgr_psoc *psoc, uint8_t pdev_id,
if (adapter->mic_work.status != MIC_INITIALIZED) {
qdf_spin_unlock_bh(&adapter->mic_work.lock);
qdf_mem_free(hdd_mic_info);
return;
goto release_ref_and_return;
}
/*
* Store mic error info pointer in adapter
@ -8024,6 +8024,9 @@ hdd_rx_mic_error_ind(struct cdp_ctrl_objmgr_psoc *psoc, uint8_t pdev_id,
adapter->mic_work.info = hdd_mic_info;
qdf_sched_work(0, &adapter->mic_work.work);
qdf_spin_unlock_bh(&adapter->mic_work.lock);
release_ref_and_return:
wlan_objmgr_pdev_release_ref(pdev, WLAN_MLME_SB_ID);
}
/* wake lock APIs for HDD */