A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-14 08:36:12 -04:00
Code Issues Projects Releases Packages Wiki Activity

msm: kgsl: Fix context leak in aux_command ioctl

Browse source 
Currently, after timeline drawobj creation it is not
immediately added to local drawobj list as a result
if kgsl_drawobj_add_timeline fails this drawobj is
leaked. As the timeline drawobj upon creation takes
a refcount on the context this leak also results in
context leak. Fix this by adding timeline drawobj to
local drawobj list immediately after creation.

Change-Id: I30f85506595ad7a7c54e82a7e850c96e7cdcbefd
Signed-off-by: Harshdeep Dhatt <hdhatt@codeaurora.org>
Signed-off-by: Deepak Kumar <dkumar@codeaurora.org>
This commit is contained in:
Harshdeep Dhatt 2021-03-18 10:55:52 +05:30 • committed by Gerrit - the friendly Code Review server
commit 8ed160d88b
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/gpu/msm/kgsl.c
View file

@ -2023,12 +2023,12 @@ long kgsl_ioctl_gpu_aux_command(struct kgsl_device_private *dev_priv,
goto err;
}
drawobjs[index++] = DRAWOBJ(timelineobj);
ret = kgsl_drawobj_add_timeline(dev_priv, timelineobj,
u64_to_user_ptr(generic.priv), generic.size);
if (ret)
goto err;
drawobjs[index++] = DRAWOBJ(timelineobj);
} else {
ret = -EINVAL;
goto err;

1
drivers/gpu/msm/kgsl_drawobj.c
View file

@ -900,6 +900,7 @@ err:
kgsl_timeline_put(timelineobj->timelines[i].timeline);
kvfree(timelineobj->timelines);
timelineobj->timelines = NULL;
return ret;
}