mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-30 03:27:44 -04:00
[PATCH] fat: remove the unneeded vfat_find() in vfat_rename()
Now, vfat_rename() is using vfat_find() for sanity check. This removes that sanity check, the cost of sanity check is too high. Signed-off-by: OGAWA Hirofumi <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
451cbaa1c3
commit
9131dd4256
2 changed files with 10 additions and 21 deletions
|
|
@ -887,10 +887,10 @@ static int vfat_rename(struct inode *old_dir, struct dentry *old_dentry,
|
|||
{
|
||||
struct buffer_head *dotdot_bh;
|
||||
struct msdos_dir_entry *dotdot_de;
|
||||
loff_t dotdot_i_pos;
|
||||
struct inode *old_inode, *new_inode;
|
||||
struct fat_slot_info old_sinfo, sinfo;
|
||||
struct timespec ts;
|
||||
loff_t dotdot_i_pos, new_i_pos;
|
||||
int err, is_dir, update_dotdot, corrupt = 0;
|
||||
|
||||
old_sinfo.bh = sinfo.bh = dotdot_bh = NULL;
|
||||
|
|
@ -913,31 +913,24 @@ static int vfat_rename(struct inode *old_dir, struct dentry *old_dentry,
|
|||
|
||||
ts = CURRENT_TIME_SEC;
|
||||
if (new_inode) {
|
||||
err = vfat_find(new_dir, &new_dentry->d_name, &sinfo);
|
||||
if (err)
|
||||
goto out;
|
||||
if (MSDOS_I(new_inode)->i_pos != sinfo.i_pos) {
|
||||
/* WTF??? Cry and fail. */
|
||||
printk(KERN_WARNING "vfat_rename: fs corrupted\n");
|
||||
goto out;
|
||||
}
|
||||
|
||||
if (is_dir) {
|
||||
err = fat_dir_empty(new_inode);
|
||||
if (err)
|
||||
goto out;
|
||||
}
|
||||
new_i_pos = MSDOS_I(new_inode)->i_pos;
|
||||
fat_detach(new_inode);
|
||||
} else {
|
||||
err = vfat_add_entry(new_dir, &new_dentry->d_name, is_dir, 0,
|
||||
&ts, &sinfo);
|
||||
if (err)
|
||||
goto out;
|
||||
new_i_pos = sinfo.i_pos;
|
||||
}
|
||||
new_dir->i_version++;
|
||||
|
||||
fat_detach(old_inode);
|
||||
fat_attach(old_inode, sinfo.i_pos);
|
||||
fat_attach(old_inode, new_i_pos);
|
||||
if (IS_DIRSYNC(new_dir)) {
|
||||
err = fat_sync_inode(old_inode);
|
||||
if (err)
|
||||
|
|
@ -1001,7 +994,7 @@ error_inode:
|
|||
fat_detach(old_inode);
|
||||
fat_attach(old_inode, old_sinfo.i_pos);
|
||||
if (new_inode) {
|
||||
fat_attach(new_inode, sinfo.i_pos);
|
||||
fat_attach(new_inode, new_i_pos);
|
||||
if (corrupt)
|
||||
corrupt |= fat_sync_inode(new_inode);
|
||||
} else {
|
||||
|
|
|
|||
Loading…
Reference in a new issue