A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-29 11:11:45 -04:00
Code Issues Projects Releases Packages Wiki Activity

cpuset: remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist()

Browse source 
It's not necessary to copy cpuset->mems_allowed to a buffer allocated by
NODEMASK_ALLOC().  Just pass it to nodelist_scnprintf().

As spotted by Paul, a side effect is we fix a bug that the function can
return -ENOMEM but the caller doesn't expect negative return value.
Therefore change the return value of cpuset_sprintf_cpulist() and
cpuset_sprintf_memlist() from int to size_t.

Signed-off-by: Li Zefan <[email protected]>
Acked-by: Paul Menage <[email protected]>
Acked-by: David Rientjes <[email protected]>
Cc: Miao Xie <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
Li Zefan 2011-03-23 16:42:45 -07:00 • committed by Linus Torvalds
commit 9303e0c481
1 changed files with 8 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

24
kernel/cpuset.c
View file

@ -1610,34 +1610,26 @@ out:
* across a page fault.
*/
static int cpuset_sprintf_cpulist(char *page, struct cpuset *cs)
static size_t cpuset_sprintf_cpulist(char *page, struct cpuset *cs)
{
int ret;
size_t count;
mutex_lock(&callback_mutex);
ret = cpulist_scnprintf(page, PAGE_SIZE, cs->cpus_allowed);
count = cpulist_scnprintf(page, PAGE_SIZE, cs->cpus_allowed);
mutex_unlock(&callback_mutex);
return ret;
return count;
}
static int cpuset_sprintf_memlist(char *page, struct cpuset *cs)
static size_t cpuset_sprintf_memlist(char *page, struct cpuset *cs)
{
NODEMASK_ALLOC(nodemask_t, mask, GFP_KERNEL);
int retval;
if (mask == NULL)
return -ENOMEM;
size_t count;
mutex_lock(&callback_mutex);
*mask = cs->mems_allowed;
count = nodelist_scnprintf(page, PAGE_SIZE, cs->mems_allowed);
mutex_unlock(&callback_mutex);
retval = nodelist_scnprintf(page, PAGE_SIZE, *mask);
NODEMASK_FREE(mask);
return retval;
return count;
}
static ssize_t cpuset_common_file_read(struct cgroup *cont,