A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-08 21:22:09 -04:00
Code Issues Projects Releases Packages Wiki Activity

clk: qcom: gdsc-regulator: correct gdsc_disable() success return value

Browse source 
Currently gdsc_disable() can return a value of 1 upon
successfully disabling a GDSC if it has a parent supply.
Correct this so that 0 is always returned on success.

Change-Id: I37ade1bf62b4e8b2f3446b9072674935579d75dd
Signed-off-by: David Collins <collinsd@codeaurora.org>
This commit is contained in:
David Collins 2020-05-01 17:16:04 -07:00
commit 98d345a332
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
drivers/clk/qcom/gdsc-regulator.c
View file

@ -321,18 +321,19 @@ static int gdsc_disable(struct regulator_dev *rdev)
{
struct gdsc *sc = rdev_get_drvdata(rdev);
uint32_t regval;
int i, ret = 0;
int i, ret = 0, parent_enabled;
if (rdev->supply) {
regulator_lock(rdev->supply->rdev);
ret = regulator_is_enabled(rdev->supply);
if (ret < 0) {
parent_enabled = regulator_is_enabled(rdev->supply);
if (parent_enabled < 0) {
ret = parent_enabled;
dev_err(&rdev->dev, "%s unable to check parent enable state, ret=%d\n",
sc->rdesc.name, ret);
goto done;
}
if (!ret) {
if (!parent_enabled) {
dev_err(&rdev->dev, "%s cannot disable GDSC while parent is disabled\n",
sc->rdesc.name);
ret = -EIO;