A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-11 23:24:22 -04:00
Code Issues Projects Releases Packages Wiki Activity

usb: f_gsi: Initiate remote-wakeup if notification already queued

Browse source 
Selective suspend of device (with remote-wakeup enabled) by host
could race with device driver queuing a notification request on
interrupt endpoint. Driver currently issues remote wakeup if at
the time of queueing notification request device was suspended.
If host suspends device right after driver queues notification
request then device driver fails to initiate remote-wakeup.
Fix this by initiating remote wakeup immediately after suspend
if notification request already queued to controller.

Change-Id: I24ce5d8302a70a1f5f68c54af0fef9f145adb97b
Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
This commit is contained in:
Manu Gautam 2018-06-20 16:39:58 +05:30 • committed by Gerrit - the friendly Code Review server
commit 99067cf7df
1 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
drivers/usb/gadget/function/f_gsi.c
View file

@ -2523,6 +2523,9 @@ static void gsi_disable(struct usb_function *f)
atomic_set(&gsi->connected, 0);
del_timer(&gsi->gsi_rw_timer);
gsi->debugfs_rw_timer_enable = 0;
if (gsi->prot_id == IPA_USB_RNDIS)
rndis_uninit(gsi->params);
@ -2578,6 +2581,16 @@ static void gsi_suspend(struct usb_function *f)
post_event(&gsi->d_port, EVT_SUSPEND);
queue_delayed_work(gsi->d_port.ipa_usb_wq, &gsi->d_port.usb_ipa_w, 0);
log_event_dbg("gsi suspended");
/*
* If host suspended bus without receiving notification request then
* initiate remote-wakeup. As driver won't be able to do it later since
* notification request is already queued.
*/
if (gsi->c_port.notify_req_queued && usb_gsi_remote_wakeup_allowed(f)) {
mod_timer(&gsi->gsi_rw_timer, jiffies + msecs_to_jiffies(2000));
log_event_dbg("%s: pending response, arm rw_timer\n", __func__);
}
}
static void gsi_resume(struct usb_function *f)
@ -2595,6 +2608,10 @@ static void gsi_resume(struct usb_function *f)
gsi->func_is_suspended)
return;
/* Keep timer enabled if user enabled using debugfs */
if (!gsi->debugfs_rw_timer_enable)
del_timer(&gsi->gsi_rw_timer);
if (gsi->c_port.notify && !gsi->c_port.notify->desc)
config_ep_by_speed(cdev->gadget, f, gsi->c_port.notify);