A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-11 23:24:22 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacmn: Fix race condition issue with enabling interrupts

Browse source 
Add lock before disabling and enabling group interrups to avoid race
condition between enabling and disabling group interrupts. Avoid mutiple
enabling/disabling of interrupts by maintaining the irq enabled information.

Change-Id: I79afc987e3853de84aaa05321cfcee72cdc0acb0
CRs-Fixed: 2087792
This commit is contained in:
Venkateswara Swamy Bandaru 2017-08-08 18:13:15 +05:30 • committed by snandini
commit 9b8dcb46d9
3 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
hif/src/hif_exec.c
View file

@ -278,6 +278,8 @@ uint32_t hif_configure_ext_group_interrupts(struct hif_opaque_softc *hif_ctx)
status = hif_grp_irq_configure(scn, hif_ext_group);
if (status != 0)
HIF_ERROR("%s: failed for group %d", __func__, i);
qdf_spinlock_create(&hif_ext_group->irq_lock);
hif_ext_group->irq_enabled = true;
}
scn->ext_grp_irq_configured = true;
@ -405,5 +407,6 @@ struct hif_exec_context *hif_exec_create(enum hif_exec_type type)
*/
void hif_exec_destroy(struct hif_exec_context *ctx)
{
qdf_spinlock_destroy(&ctx->irq_lock);
qdf_mem_free(ctx);
}

2
hif/src/hif_exec.h
View file

@ -69,6 +69,8 @@ struct hif_exec_context {
bool inited;
bool configured;
bool irq_requested;
bool irq_enabled;
qdf_spinlock_t irq_lock;
};
/**

18
hif/src/snoc/if_ahb.c
View file

@ -687,17 +687,27 @@ void hif_ahb_exec_grp_irq_disable(struct hif_exec_context *hif_ext_group)
{
int i;
for (i = 0; i < hif_ext_group->numirq; i++) {
disable_irq_nosync(hif_ext_group->os_irq[i]);
qdf_spin_lock_irqsave(&hif_ext_group->irq_lock);
if (hif_ext_group->irq_enabled) {
for (i = 0; i < hif_ext_group->numirq; i++) {
disable_irq_nosync(hif_ext_group->os_irq[i]);
}
hif_ext_group->irq_enabled = false;
}
qdf_spin_unlock_irqrestore(&hif_ext_group->irq_lock);
}
void hif_ahb_exec_grp_irq_enable(struct hif_exec_context *hif_ext_group)
{
int i;
for (i = 0; i < hif_ext_group->numirq; i++) {
enable_irq(hif_ext_group->os_irq[i]);
qdf_spin_lock_irqsave(&hif_ext_group->irq_lock);
if (!hif_ext_group->irq_enabled) {
for (i = 0; i < hif_ext_group->numirq; i++) {
enable_irq(hif_ext_group->os_irq[i]);
}
hif_ext_group->irq_enabled = true;
}
qdf_spin_unlock_irqrestore(&hif_ext_group->irq_lock);
}