A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-09 13:49:24 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Check if NAPI ptr is NULL

Browse source 
Check if pointer returned by hdd_napi_get_all is NULL. This would prevent
de-referencing of NULL pointer.

Change-Id: I23af3319422e0d2ebd93ce410d76457c54551538
CRs-Fixed: 2299788
This commit is contained in:
Amar Singhal 2018-09-04 12:46:25 -07:00
commit 9babc67597
1 changed files with 34 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

64
core/hdd/src/wlan_hdd_napi.c
View file

@ -102,40 +102,48 @@ int hdd_napi_create(void)
NAPI_DEBUG("-->");
if (NULL == napid) {
hdd_err("unable to retrieve napi structure");
rc = -EFAULT;
goto exit;
}
hif_ctx = cds_get_context(QDF_MODULE_ID_HIF);
if (unlikely(NULL == hif_ctx)) {
QDF_ASSERT(NULL != hif_ctx);
rc = -EFAULT;
} else {
feature_flags = QCA_NAPI_FEATURE_CPU_CORRECTION |
QCA_NAPI_FEATURE_IRQ_BLACKLISTING |
QCA_NAPI_FEATURE_CORE_CTL_BOOST;
rc = hif_napi_create(hif_ctx, hdd_napi_poll,
QCA_NAPI_BUDGET,
QCA_NAPI_DEF_SCALE,
feature_flags);
if (rc < 0) {
hdd_err("ERR(%d) creating NAPI instances",
rc);
} else {
hdd_debug("napi instances were created. Map=0x%x", rc);
hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
if (unlikely(NULL == hdd_ctx)) {
QDF_ASSERT(0);
rc = -EFAULT;
} else {
rc = hdd_napi_event(NAPI_EVT_INI_FILE,
(void *)hdd_ctx->napi_enable);
napid->user_cpu_affin_mask =
hdd_ctx->config->napi_cpu_affinity_mask;
}
}
goto exit;
}
NAPI_DEBUG("<-- [rc=%d]", rc);
feature_flags = QCA_NAPI_FEATURE_CPU_CORRECTION |
QCA_NAPI_FEATURE_IRQ_BLACKLISTING |
QCA_NAPI_FEATURE_CORE_CTL_BOOST;
rc = hif_napi_create(hif_ctx, hdd_napi_poll,
QCA_NAPI_BUDGET,
QCA_NAPI_DEF_SCALE,
feature_flags);
if (rc < 0) {
hdd_err("ERR(%d) creating NAPI instances",
rc);
goto exit;
}
hdd_debug("napi instances were created. Map=0x%x", rc);
hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
if (unlikely(NULL == hdd_ctx)) {
QDF_ASSERT(0);
rc = -EFAULT;
goto exit;
}
rc = hdd_napi_event(NAPI_EVT_INI_FILE,
(void *)hdd_ctx->napi_enable);
napid->user_cpu_affin_mask =
hdd_ctx->config->napi_cpu_affinity_mask;
exit:
NAPI_DEBUG("<-- [rc=%d]", rc);
return rc;
}