A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-28 18:51:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

firewire: fix memory leak of fw_request instances

Browse source 
Found and debugged by Jay Fenlason <[email protected]>.
The bug was especially noticeable with direct I/O over fw-sbp2.

Signed-off-by: Stefan Richter <[email protected]>
Signed-off-by: Kristian Høgsberg <[email protected]>
This commit is contained in:
Stefan Richter 2007-07-17 02:15:36 +02:00
commit 9c9bdf4d50
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/firewire/fw-transaction.c
View file

@ -605,8 +605,10 @@ fw_send_response(struct fw_card *card, struct fw_request *request, int rcode)
* check is sufficient to ensure we don't send response to
* broadcast packets or posted writes.
*/
if (request->ack != ACK_PENDING)
if (request->ack != ACK_PENDING) {
kfree(request);
return;
}
if (rcode == RCODE_COMPLETE)
fw_fill_response(&request->response, request->request_header,

4
drivers/firewire/fw-transaction.h
View file

@ -123,6 +123,10 @@ typedef void (*fw_transaction_callback_t)(struct fw_card *card, int rcode,
size_t length,
void *callback_data);
/*
* Important note: The callback must guarantee that either fw_send_response()
* or kfree() is called on the @request.
*/
typedef void (*fw_address_callback_t)(struct fw_card *card,
struct fw_request *request,
int tcode, int destination, int source,