mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-30 03:27:44 -04:00
NFC: netlink: Rename CMD_FW_UPLOAD to CMD_FW_DOWNLOAD
Loading a firmware into a target is typically called firmware download, not firmware upload. So we rename the netlink API to NFC_CMD_FW_DOWNLOAD in order to avoid any terminology confusion from userspace. Signed-off-by: Samuel Ortiz <[email protected]>
This commit is contained in:
parent
7427b370e0
commit
9ea7187c53
7 changed files with 29 additions and 29 deletions
|
|
@ -44,7 +44,7 @@ DEFINE_MUTEX(nfc_devlist_mutex);
|
|||
/* NFC device ID bitmap */
|
||||
static DEFINE_IDA(nfc_index_ida);
|
||||
|
||||
int nfc_fw_upload(struct nfc_dev *dev, const char *firmware_name)
|
||||
int nfc_fw_download(struct nfc_dev *dev, const char *firmware_name)
|
||||
{
|
||||
int rc = 0;
|
||||
|
||||
|
|
@ -62,28 +62,28 @@ int nfc_fw_upload(struct nfc_dev *dev, const char *firmware_name)
|
|||
goto error;
|
||||
}
|
||||
|
||||
if (!dev->ops->fw_upload) {
|
||||
if (!dev->ops->fw_download) {
|
||||
rc = -EOPNOTSUPP;
|
||||
goto error;
|
||||
}
|
||||
|
||||
dev->fw_upload_in_progress = true;
|
||||
rc = dev->ops->fw_upload(dev, firmware_name);
|
||||
dev->fw_download_in_progress = true;
|
||||
rc = dev->ops->fw_download(dev, firmware_name);
|
||||
if (rc)
|
||||
dev->fw_upload_in_progress = false;
|
||||
dev->fw_download_in_progress = false;
|
||||
|
||||
error:
|
||||
device_unlock(&dev->dev);
|
||||
return rc;
|
||||
}
|
||||
|
||||
int nfc_fw_upload_done(struct nfc_dev *dev, const char *firmware_name)
|
||||
int nfc_fw_download_done(struct nfc_dev *dev, const char *firmware_name)
|
||||
{
|
||||
dev->fw_upload_in_progress = false;
|
||||
dev->fw_download_in_progress = false;
|
||||
|
||||
return nfc_genl_fw_upload_done(dev, firmware_name);
|
||||
return nfc_genl_fw_download_done(dev, firmware_name);
|
||||
}
|
||||
EXPORT_SYMBOL(nfc_fw_upload_done);
|
||||
EXPORT_SYMBOL(nfc_fw_download_done);
|
||||
|
||||
/**
|
||||
* nfc_dev_up - turn on the NFC device
|
||||
|
|
@ -110,7 +110,7 @@ int nfc_dev_up(struct nfc_dev *dev)
|
|||
goto error;
|
||||
}
|
||||
|
||||
if (dev->fw_upload_in_progress) {
|
||||
if (dev->fw_download_in_progress) {
|
||||
rc = -EBUSY;
|
||||
goto error;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -809,14 +809,14 @@ static void nfc_hci_recv_from_llc(struct nfc_hci_dev *hdev, struct sk_buff *skb)
|
|||
}
|
||||
}
|
||||
|
||||
static int hci_fw_upload(struct nfc_dev *nfc_dev, const char *firmware_name)
|
||||
static int hci_fw_download(struct nfc_dev *nfc_dev, const char *firmware_name)
|
||||
{
|
||||
struct nfc_hci_dev *hdev = nfc_get_drvdata(nfc_dev);
|
||||
|
||||
if (!hdev->ops->fw_upload)
|
||||
if (!hdev->ops->fw_download)
|
||||
return -ENOTSUPP;
|
||||
|
||||
return hdev->ops->fw_upload(hdev, firmware_name);
|
||||
return hdev->ops->fw_download(hdev, firmware_name);
|
||||
}
|
||||
|
||||
static struct nfc_ops hci_nfc_ops = {
|
||||
|
|
@ -831,7 +831,7 @@ static struct nfc_ops hci_nfc_ops = {
|
|||
.im_transceive = hci_transceive,
|
||||
.tm_send = hci_tm_send,
|
||||
.check_presence = hci_check_presence,
|
||||
.fw_upload = hci_fw_upload,
|
||||
.fw_download = hci_fw_download,
|
||||
.discover_se = hci_discover_se,
|
||||
.enable_se = hci_enable_se,
|
||||
.disable_se = hci_disable_se,
|
||||
|
|
|
|||
|
|
@ -1089,7 +1089,7 @@ exit:
|
|||
return rc;
|
||||
}
|
||||
|
||||
static int nfc_genl_fw_upload(struct sk_buff *skb, struct genl_info *info)
|
||||
static int nfc_genl_fw_download(struct sk_buff *skb, struct genl_info *info)
|
||||
{
|
||||
struct nfc_dev *dev;
|
||||
int rc;
|
||||
|
|
@ -1108,13 +1108,13 @@ static int nfc_genl_fw_upload(struct sk_buff *skb, struct genl_info *info)
|
|||
nla_strlcpy(firmware_name, info->attrs[NFC_ATTR_FIRMWARE_NAME],
|
||||
sizeof(firmware_name));
|
||||
|
||||
rc = nfc_fw_upload(dev, firmware_name);
|
||||
rc = nfc_fw_download(dev, firmware_name);
|
||||
|
||||
nfc_put_device(dev);
|
||||
return rc;
|
||||
}
|
||||
|
||||
int nfc_genl_fw_upload_done(struct nfc_dev *dev, const char *firmware_name)
|
||||
int nfc_genl_fw_download_done(struct nfc_dev *dev, const char *firmware_name)
|
||||
{
|
||||
struct sk_buff *msg;
|
||||
void *hdr;
|
||||
|
|
@ -1124,7 +1124,7 @@ int nfc_genl_fw_upload_done(struct nfc_dev *dev, const char *firmware_name)
|
|||
return -ENOMEM;
|
||||
|
||||
hdr = genlmsg_put(msg, 0, 0, &nfc_genl_family, 0,
|
||||
NFC_CMD_FW_UPLOAD);
|
||||
NFC_CMD_FW_DOWNLOAD);
|
||||
if (!hdr)
|
||||
goto free_msg;
|
||||
|
||||
|
|
@ -1251,8 +1251,8 @@ static struct genl_ops nfc_genl_ops[] = {
|
|||
.policy = nfc_genl_policy,
|
||||
},
|
||||
{
|
||||
.cmd = NFC_CMD_FW_UPLOAD,
|
||||
.doit = nfc_genl_fw_upload,
|
||||
.cmd = NFC_CMD_FW_DOWNLOAD,
|
||||
.doit = nfc_genl_fw_download,
|
||||
.policy = nfc_genl_policy,
|
||||
},
|
||||
{
|
||||
|
|
|
|||
|
|
@ -123,10 +123,10 @@ static inline void nfc_device_iter_exit(struct class_dev_iter *iter)
|
|||
class_dev_iter_exit(iter);
|
||||
}
|
||||
|
||||
int nfc_fw_upload(struct nfc_dev *dev, const char *firmware_name);
|
||||
int nfc_genl_fw_upload_done(struct nfc_dev *dev, const char *firmware_name);
|
||||
int nfc_fw_download(struct nfc_dev *dev, const char *firmware_name);
|
||||
int nfc_genl_fw_download_done(struct nfc_dev *dev, const char *firmware_name);
|
||||
|
||||
int nfc_fw_upload_done(struct nfc_dev *dev, const char *firmware_name);
|
||||
int nfc_fw_download_done(struct nfc_dev *dev, const char *firmware_name);
|
||||
|
||||
int nfc_dev_up(struct nfc_dev *dev);
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue