From f5ab798784f434f3923feb8ff3c027afc51ddf57 Mon Sep 17 00:00:00 2001 From: Subbaraman Narayanamurthy Date: Mon, 10 Aug 2020 19:40:57 -0700 Subject: [PATCH] leds: qti-flash: Handle error return path properly Currently if qti_flash_lmh_mitigation_config() returns an error in qti_flash_led_strobe(), spin_unlock() is not called in the error return path. Fix it. Fixes: 42bdecad7ccd7 ("leds: qti-flash: Fix LMH mitigation configuration") Change-Id: I1bede93873a151cc9bab7f2000d8f058e1890fda Signed-off-by: Subbaraman Narayanamurthy --- drivers/leds/leds-qti-flash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-qti-flash.c b/drivers/leds/leds-qti-flash.c index 9939f4968a80..8db62e7e9589 100644 --- a/drivers/leds/leds-qti-flash.c +++ b/drivers/leds/leds-qti-flash.c @@ -362,7 +362,7 @@ static int qti_flash_led_strobe(struct qti_flash_led *led, if (led->trigger_lmh) { rc = qti_flash_lmh_mitigation_config(led, true); if (rc < 0) - return rc; + goto error; /* Wait for LMH mitigation to take effect */ udelay(500); @@ -386,7 +386,7 @@ static int qti_flash_led_strobe(struct qti_flash_led *led, if (led->trigger_lmh) { rc = qti_flash_lmh_mitigation_config(led, false); if (rc < 0) - return rc; + goto error; led->trigger_lmh = false; }