From a215b92aa28bac153e7498e6dc83b9e67b72da62 Mon Sep 17 00:00:00 2001 From: Rohith Kollalsi Date: Mon, 6 Jul 2020 19:00:12 +0530 Subject: [PATCH] usb: u_ether: Add null pointer check for sk_buff in eth_start_xmit There is a possibility of null pointer dereference for sk_buff in the function eth_start_xmit. Fix this by removing sk_buff from if check at the start of the function eth_start_xmit so that if sk_buff is null dev_kfree_skb_any will return without proceeding further. Change-Id: I105e42c59aaa83c8d74cc5a9e894ae4fc87c3c9f Signed-off-by: Rohith Kollalsi --- drivers/usb/gadget/function/u_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index fbe96ef1ac7a..051469887a5a 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -490,7 +490,7 @@ static netdev_tx_t eth_start_xmit(struct sk_buff *skb, } spin_unlock_irqrestore(&dev->lock, flags); - if (skb && !in) { + if (!in) { dev_kfree_skb_any(skb); return NETDEV_TX_OK; }