From a221c54d72094d5845cdbd509f4c7b92ea9061f1 Mon Sep 17 00:00:00 2001 From: Jordan Crouse Date: Tue, 29 Jan 2019 08:28:08 -0700 Subject: [PATCH] soc: qcom: smp2p: Fix two warnings drivers/soc/qcom/smp2p.c: In function 'qcom_smp2p_do_ssr_ack': drivers/soc/qcom/smp2p.c:214:2: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] drivers/soc/qcom/smp2p.c: In function 'qcom_smp2p_notify_in': drivers/soc/qcom/smp2p.c:176:23: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'long unsigned int' [-Werror=format=] drivers/soc/qcom/smp2p.c:281:3: note: in expansion of macro 'SMP2P_INFO'. Fixes: 322d40176558 ("soc: qcom: smp2p: Add snapshot of smp2p driver") Change-Id: Ic0dedbadbe4e61dd53e7bb22c54c2eb2ca94eb48 Signed-off-by: Jordan Crouse --- drivers/soc/qcom/smp2p.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index 7c5a7c6fd782..98035a7681f5 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -205,7 +205,8 @@ static void qcom_smp2p_do_ssr_ack(struct qcom_smp2p *smp2p) u32 ack; u32 val; - smp2p->ssr_ack = ack = !smp2p->ssr_ack; + ack = !smp2p->ssr_ack; + smp2p->ssr_ack = ack; ack = ack << SMP2P_FLAGS_RESTART_ACK_BIT; val = out->flags & ~BIT(SMP2P_FLAGS_RESTART_ACK_BIT); @@ -272,7 +273,7 @@ static void qcom_smp2p_notify_in(struct qcom_smp2p *smp2p) if (!status) continue; - SMP2P_INFO("%d: %s: status:%0x val:%0x\n", + SMP2P_INFO("%d: %s: status:%0lx val:%0x\n", smp2p->remote_pid, entry->name, status, val); for_each_set_bit(i, &status, 32) {