A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-07 04:12:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

checkpatch: warn on subject line not followed by blank line

Browse source 
Fixed case when no warning generated for long subject line that is
wrapped to more than one line, and all lines are less than line limit.

New warning message added:
"non-blank line after summary line"
Now there are two warnings possible for the subject line, the original
line over limit and the new one. Depending on the error(s) any
combination of the two warnings are possible.

Commit text requirements now:
1) Must be less than 75 characters
2) Must be followed by blank line.

Change-Id: Id28d7a2eee561a1b1f45e51e346be3868c1fbad5
Signed-off-by: David Keitel <dkeitel@codeaurora.org>
This commit is contained in:
David Keitel 2016-03-23 20:57:21 -07:00 • committed by Raghavendra Rao Ananta
commit a2d6e2ef6e
1 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
scripts/checkpatch.pl
View file

@ -18,6 +18,7 @@ use Encode qw(decode encode);
use constant BEFORE_SHORTTEXT => 0;
use constant IN_SHORTTEXT => 1;
use constant AFTER_SHORTTEXT => 2;
use constant CHECK_NEXT_SHORTTEXT => 3;
use constant SHORTTEXT_LIMIT => 75;
my $P = $0;
@ -2279,6 +2280,8 @@ sub process {
my $prevrawline="";
my $stashline="";
my $stashrawline="";
my $subjectline="";
my $sublinenr="";
my $length;
my $indent;
@ -2578,8 +2581,21 @@ sub process {
SHORTTEXT_LIMIT .
" characters\n" . $herecurr);
}
} elsif ($line=~/^Subject: \[[^\]]*\] (.*)/) {
} elsif ($shorttext == CHECK_NEXT_SHORTTEXT) {
$shorttext = IN_SHORTTEXT;
# Check for Subject line followed by a blank line.
if (length($line) != 0) {
WARN("NONBLANK_AFTER_SUMMARY",
"non-blank line after summary " .
"line\n" . $sublinenr . $here .
"\n" . $subjectline . "\n" .
$line . "\n");
}
} elsif ($line=~/^Subject: \[[^\]]*\] (.*)/) {
$shorttext = CHECK_NEXT_SHORTTEXT;
$subjectline = $line;
$sublinenr = "#$linenr & ";
# Check for Subject line less than line limit
if (length($1) > SHORTTEXT_LIMIT) {
WARN("LONG_SUMMARY_LINE",
"summary line over " .