From a3415ed80dda3cc5c01ce150b6d6fa4ab20da820 Mon Sep 17 00:00:00 2001 From: gaurank kathpalia Date: Thu, 25 Apr 2019 18:37:34 +0530 Subject: [PATCH] qcacld-3.0: Remove check of hw mode from connect path Currently the driver checks that whether DBS connection is allowed in concurrency or not, and if it is not allowed, MCC should happen. But the check of policy_mgr_is_hwmode_set_for_given_chnl blocks the connection in MCC, because it checks whether the DBS mode is set or not, which should not be case always, for example in MCC case scenarios, or SBS case scenarios in future. Lets take a case scenario to understand this :- 1. Keep the ini channel_select_logic_conc = 0 this would disable the dbs for STA+STA/P2P-CLI 2. Turn on the above concurrency combinations in diff band 3. The expectation should be MCC as DBS for this combination is disabled, but this is not the observation. here the vdev that comes up next, would fail as MCC is rejected in policy_mgr_is_hwmode_set_for_given_chn, and DBS is not allowed according to the check in policy_mgr_is_dbs_allowed_for_concurrency hence the combination mentioned above cannot be achieved with this check. Fix is to remove the check of dbs from API policy_mgr_is_hwmode_set_for_given_chnl. Change-Id: I4260f3229658b753f98a106e5580b6c18f7ac0ff CRs-Fixed: 2442533 --- .../policy_mgr/src/wlan_policy_mgr_action.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/components/cmn_services/policy_mgr/src/wlan_policy_mgr_action.c b/components/cmn_services/policy_mgr/src/wlan_policy_mgr_action.c index 9cbe44bfaf7e..ec7384e72211 100644 --- a/components/cmn_services/policy_mgr/src/wlan_policy_mgr_action.c +++ b/components/cmn_services/policy_mgr/src/wlan_policy_mgr_action.c @@ -538,17 +538,6 @@ bool policy_mgr_is_hwmode_set_for_given_chnl(struct wlan_objmgr_psoc *psoc, return false; } - /* - * If HW supports 1x1 chains DBS HW mode and if first connection is - * 2G or 5G band and if second connection is coming up in diffrent - * band than the first connection and if current HW mode is not yet - * set in DBS then this is the right time to block the connection. - */ - if (policy_mgr_is_chnl_in_diff_band(psoc, channel) && !is_hwmode_dbs) { - policy_mgr_err("Given channel & existing conn is diff band & HW mode is not yet in DBS !!!!"); - return false; - } - return true; }