From a3be364dfbf24c71a5e63cdbe0d10044b5e3cf92 Mon Sep 17 00:00:00 2001 From: jitiphil Date: Fri, 16 Nov 2018 14:17:27 +0530 Subject: [PATCH] qcacmn: Free buffer in ath_procfs_diag_read A read buffer is allocated and used in ath_procfs_diag_read and it is not freed in one exit path which causes a memory leak Free read buffer in all exit paths of ath_procfs_diag_read Change-Id: I1b2446a99f53c2f9130d395dd316eb4649eb24db CRs-Fixed: 2352165 --- hif/src/ath_procfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hif/src/ath_procfs.c b/hif/src/ath_procfs.c index 5c9837fefd6c..57514372f28d 100644 --- a/hif/src/ath_procfs.c +++ b/hif/src/ath_procfs.c @@ -108,8 +108,10 @@ static ssize_t ath_procfs_diag_read(struct file *file, char __user *buf, } out: - if (rv) + if (rv) { + qdf_mem_free(read_buffer); return -EIO; + } if (copy_to_user(buf, read_buffer, count)) { qdf_mem_free(read_buffer);