From a5fb21806a42459722049fc2ac16889c0cebbefd Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Fri, 6 Oct 2017 20:27:38 -0700 Subject: [PATCH] qcacld-3.0: Remove unnecessary else in hdd_indicate_tsf_internal() Checkpatch has detected one instance of "else is not generally useful after a break or return" in hdd_indicate_tsf_internal(), so fix it. Change-Id: I6aa92cc7966795e719eb5824a3a9354928e79590 CRs-Fixed: 2122872 --- core/hdd/src/wlan_hdd_tsf.c | 41 +++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/core/hdd/src/wlan_hdd_tsf.c b/core/hdd/src/wlan_hdd_tsf.c index 452bef6eb42b..740b708423fb 100644 --- a/core/hdd/src/wlan_hdd_tsf.c +++ b/core/hdd/src/wlan_hdd_tsf.c @@ -245,30 +245,31 @@ static enum hdd_tsf_op_result hdd_indicate_tsf_internal( hdd_info("TSF value not received"); buf[0] = TSF_NOT_RETURNED_BY_FW; return HDD_TSF_OP_SUCC; - } else { - buf[0] = TSF_RETURN; - buf[1] = (uint32_t)(adapter->cur_target_time & 0xffffffff); - buf[2] = (uint32_t)((adapter->cur_target_time >> 32) & + } + + buf[0] = TSF_RETURN; + buf[1] = (uint32_t)(adapter->cur_target_time & 0xffffffff); + buf[2] = (uint32_t)((adapter->cur_target_time >> 32) & 0xffffffff); - if (!qdf_atomic_read(&hddctx->cap_tsf_flag)) { - hdd_info("old: status=%u, tsf_low=%u, tsf_high=%u", - buf[0], buf[1], buf[2]); - return HDD_TSF_OP_SUCC; - } - - ret = hdd_tsf_reset_gpio(adapter); - if (0 != ret) { - hdd_err("reset tsf gpio fail"); - buf[0] = TSF_RESET_GPIO_FAIL; - return HDD_TSF_OP_SUCC; - } - hddctx->cap_tsf_context = NULL; - qdf_atomic_set(&hddctx->cap_tsf_flag, 0); - hdd_info("get tsf cmd,status=%u, tsf_low=%u, tsf_high=%u", - buf[0], buf[1], buf[2]); + if (!qdf_atomic_read(&hddctx->cap_tsf_flag)) { + hdd_info("old: status=%u, tsf_low=%u, tsf_high=%u", + buf[0], buf[1], buf[2]); return HDD_TSF_OP_SUCC; } + + ret = hdd_tsf_reset_gpio(adapter); + if (0 != ret) { + hdd_err("reset tsf gpio fail"); + buf[0] = TSF_RESET_GPIO_FAIL; + return HDD_TSF_OP_SUCC; + } + hddctx->cap_tsf_context = NULL; + qdf_atomic_set(&hddctx->cap_tsf_flag, 0); + hdd_info("get tsf cmd,status=%u, tsf_low=%u, tsf_high=%u", + buf[0], buf[1], buf[2]); + + return HDD_TSF_OP_SUCC; } #ifdef WLAN_FEATURE_TSF_PLUS