From a7bb6ae8f1b2ea9424ae26d3b7bca639b420fbd8 Mon Sep 17 00:00:00 2001 From: Dustin Brown Date: Thu, 16 Aug 2018 16:51:50 -0700 Subject: [PATCH] qcacld-3.0: Reduce excessive HDD logs Several HDD logs have been identified as being excessive. Reduce the logging level of these logs to avoid spamming dmesg. Change-Id: I49e0f91c5d66051f9e6ffd991d86505a11faa346 CRs-Fixed: 2298385 --- core/hdd/src/wlan_hdd_assoc.c | 2 +- core/hdd/src/wlan_hdd_cfg.c | 6 +++--- core/hdd/src/wlan_hdd_cfg80211.c | 8 ++++---- core/hdd/src/wlan_hdd_green_ap.c | 4 ++-- core/hdd/src/wlan_hdd_main.c | 26 +++++++++++++------------- core/hdd/src/wlan_hdd_subnet_detect.c | 12 +++++------- 6 files changed, 28 insertions(+), 30 deletions(-) diff --git a/core/hdd/src/wlan_hdd_assoc.c b/core/hdd/src/wlan_hdd_assoc.c index a389031ea759..694f65593ca2 100644 --- a/core/hdd/src/wlan_hdd_assoc.c +++ b/core/hdd/src/wlan_hdd_assoc.c @@ -4618,7 +4618,7 @@ hdd_sme_roam_callback(void *pContext, struct csr_roam_info *roam_info, break; case eCSR_ROAM_SHOULD_ROAM: /* notify apps that we can't pass traffic anymore */ - hdd_info("Disabling queues"); + hdd_debug("Disabling queues"); wlan_hdd_netif_queue_control(adapter, WLAN_STOP_ALL_NETIF_QUEUE, WLAN_CONTROL_PATH); diff --git a/core/hdd/src/wlan_hdd_cfg.c b/core/hdd/src/wlan_hdd_cfg.c index aa621067120c..cae7ec159ddb 100644 --- a/core/hdd/src/wlan_hdd_cfg.c +++ b/core/hdd/src/wlan_hdd_cfg.c @@ -6184,9 +6184,9 @@ static void hdd_cfg_print_sae(struct hdd_context *hdd_ctx) #ifdef CONFIG_DP_TRACE static void hdd_cfg_print_dp_trace_params(struct hdd_context *hdd_ctx) { - hdd_info("Name = [%s] Value = [%u]", - CFG_ENABLE_DP_TRACE, - hdd_ctx->config->enable_dp_trace); + hdd_debug("Name = [%s] Value = [%u]", + CFG_ENABLE_DP_TRACE, + hdd_ctx->config->enable_dp_trace); hdd_debug("Name = [%s] Value = [%s]", CFG_ENABLE_DP_TRACE_CONFIG, hdd_ctx->config->dp_trace_config); diff --git a/core/hdd/src/wlan_hdd_cfg80211.c b/core/hdd/src/wlan_hdd_cfg80211.c index cca1d802f3f8..cd9ec2c3ed86 100644 --- a/core/hdd/src/wlan_hdd_cfg80211.c +++ b/core/hdd/src/wlan_hdd_cfg80211.c @@ -3169,8 +3169,8 @@ __wlan_hdd_cfg80211_set_scanning_mac_oui(struct wiphy *wiphy, if (ret) return ret; - if (false == hdd_ctx->config->enable_mac_spoofing) { - hdd_warn("MAC address spoofing is not enabled"); + if (!hdd_ctx->config->enable_mac_spoofing) { + hdd_debug("MAC address spoofing is not enabled"); return -ENOTSUPP; } @@ -16821,8 +16821,8 @@ static int __wlan_hdd_cfg80211_disconnect(struct wiphy *wiphy, hdd_notify_sta_disconnect(adapter->session_id, false, true, adapter->hdd_vdev); - hdd_info("Disconnect request from user space with reason: %d (%s) internal reason code: %d", - reason, hdd_ieee80211_reason_code_to_str(reason), reasonCode); + hdd_info("Disconnect from userspace; reason:%d (%s)", + reason, hdd_ieee80211_reason_code_to_str(reason)); status = wlan_hdd_disconnect(adapter, reasonCode); if (0 != status) { hdd_err("wlan_hdd_disconnect failed, status: %d", status); diff --git a/core/hdd/src/wlan_hdd_green_ap.c b/core/hdd/src/wlan_hdd_green_ap.c index ffbad54f8c2b..be18522b3147 100644 --- a/core/hdd/src/wlan_hdd_green_ap.c +++ b/core/hdd/src/wlan_hdd_green_ap.c @@ -137,8 +137,8 @@ int hdd_green_ap_start_state_mc(struct hdd_context *hdd_ctx, } if (!cfg->enable2x2 || !cfg->enable_green_ap) { - hdd_info("Green AP support not present: enable2x2: %d, enable_green_ap: %d", - cfg->enable2x2, cfg->enable_green_ap); + hdd_debug("Green AP not enabled: enable2x2:%d, enable_green_ap:%d", + cfg->enable2x2, cfg->enable_green_ap); return 0; } diff --git a/core/hdd/src/wlan_hdd_main.c b/core/hdd/src/wlan_hdd_main.c index a754d78658df..f99b78b19823 100644 --- a/core/hdd/src/wlan_hdd_main.c +++ b/core/hdd/src/wlan_hdd_main.c @@ -608,7 +608,7 @@ static int __hdd_netdev_notifier_call(struct notifier_block *nb, } if (hdd_ctx->driver_status == DRIVER_MODULES_CLOSED) { - hdd_err("%s: Driver module is closed", __func__); + hdd_debug("%s: Driver module is closed", __func__); return NOTIFY_DONE; } @@ -3254,9 +3254,9 @@ static int __hdd_stop(struct net_device *dev) * Disable TX on the interface, after this hard_start_xmit() will not * be called on that interface */ - hdd_info("Disabling queues, adapter device mode: %s(%d)", - hdd_device_mode_to_string(adapter->device_mode), - adapter->device_mode); + hdd_debug("Disabling queues, adapter device mode: %s(%d)", + hdd_device_mode_to_string(adapter->device_mode), + adapter->device_mode); wlan_hdd_netif_queue_control(adapter, WLAN_STOP_ALL_NETIF_QUEUE_N_CARRIER, @@ -4505,25 +4505,25 @@ static int hdd_configure_chain_mask(struct hdd_adapter *adapter) non_dbs_phy_cap.rx_chain_mask_2G < 3 || non_dbs_phy_cap.tx_chain_mask_5G < 3 || non_dbs_phy_cap.rx_chain_mask_5G < 3) { - hdd_info("firmware not capable. skip chain mask programming"); + hdd_debug("firmware not capable. skip chain mask programming"); return 0; } if (hdd_ctx->config->enable2x2 && !hdd_ctx->config->enable_bt_chain_separation) { - hdd_info("2x2 enabled. skip chain mask programming"); + hdd_debug("2x2 enabled. skip chain mask programming"); return 0; } if (hdd_ctx->config->dual_mac_feature_disable != DISABLE_DBS_CXN_AND_SCAN) { - hdd_info("DBS enabled(%d). skip chain mask programming", - hdd_ctx->config->dual_mac_feature_disable); + hdd_debug("DBS enabled(%d). skip chain mask programming", + hdd_ctx->config->dual_mac_feature_disable); return 0; } if (hdd_ctx->lte_coex_ant_share) { - hdd_info("lte ant sharing enabled. skip chainmask programming"); + hdd_debug("lte ant sharing enabled. skip chainmask programming"); return 0; } @@ -4547,7 +4547,7 @@ static int hdd_configure_chain_mask(struct hdd_adapter *adapter) if (hdd_ctx->config->txchainmask1x1 || hdd_ctx->config->rxchainmask1x1) { - hdd_info("band agnostic tx/rx chain mask set. skip per band chain mask"); + hdd_debug("band agnostic tx/rx chain mask set. skip per band chain mask"); return 0; } @@ -11134,9 +11134,9 @@ void hdd_dp_trace_init(struct hdd_config *config) live_mode = config_params[0]; /* fall through */ default: - hdd_info("live_mode %u thresh %u time_limit %u verbosity %u bitmap 0x%x", - live_mode, thresh, thresh_time_limit, - verbosity, proto_bitmap); + hdd_debug("live_mode %u thresh %u time_limit %u verbosity %u bitmap 0x%x", + live_mode, thresh, thresh_time_limit, + verbosity, proto_bitmap); }; qdf_dp_trace_init(live_mode, thresh, thresh_time_limit, diff --git a/core/hdd/src/wlan_hdd_subnet_detect.c b/core/hdd/src/wlan_hdd_subnet_detect.c index a65b545c687d..ae2d2b8b4721 100644 --- a/core/hdd/src/wlan_hdd_subnet_detect.c +++ b/core/hdd/src/wlan_hdd_subnet_detect.c @@ -146,13 +146,11 @@ static int __wlan_hdd_cfg80211_set_gateway_params(struct wiphy *wiphy, req.timeout = 100; /* in milliseconds */ req.session_id = adapter->session_id; - hdd_info("**** Gateway Parameters: ****"); - hdd_info("session id: %d", req.session_id); - hdd_info("ipv4 addr type: %d", req.ipv4_addr_type); - hdd_info("ipv6 addr type: %d", req.ipv6_addr_type); - hdd_info("gw mac addr: %pM", req.gw_mac_addr.bytes); - hdd_info("ipv4 addr: %pI4", req.ipv4_addr); - hdd_info("ipv6 addr: %pI6c", req.ipv6_addr); + hdd_debug("Configuring gateway for session %d", req.session_id); + hdd_debug("mac:%pM, ipv4:%pI4 (type %d), ipv6:%pI6c (type %d)", + req.gw_mac_addr.bytes, + req.ipv4_addr, req.ipv4_addr_type, + req.ipv6_addr, req.ipv6_addr_type); hdd_nud_set_gateway_addr(adapter, req.gw_mac_addr);