From a7ef89abb13ab1a03317b56531b0832afbff3daf Mon Sep 17 00:00:00 2001 From: Varun Reddy Yeturu Date: Thu, 21 Dec 2017 15:19:58 -0800 Subject: [PATCH] qcacmn: Ensure legacy_callback is not NULL before calling Check legacy_callback function pointer is non NULL before calling the function Change-Id: I4953b87486214f704eaf357e663f0fbc310fb965 CRs-Fixed: 2160759 --- target_if/init_deinit/src/service_ready_event_handler.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/target_if/init_deinit/src/service_ready_event_handler.c b/target_if/init_deinit/src/service_ready_event_handler.c index 5e450a35f903..49598b48483d 100644 --- a/target_if/init_deinit/src/service_ready_event_handler.c +++ b/target_if/init_deinit/src/service_ready_event_handler.c @@ -111,6 +111,10 @@ int init_deinit_service_ready_event_handler(ol_scn_t scn_handle, goto free_param_and_exit; legacy_callback = target_if_get_psoc_legacy_service_ready_cb(); + if (!legacy_callback) { + err_code = -EINVAL; + goto free_param_and_exit; + } err_code = legacy_callback(wmi_service_ready_event_id, scn_handle, event, data_len); @@ -372,6 +376,10 @@ int init_deinit_service_ext_ready_event_handler(ol_scn_t scn_handle, wlan_objmgr_populate_ext_service_ready_data(psoc, service_param); legacy_callback = target_if_get_psoc_legacy_service_ready_cb(); + if (!legacy_callback) { + err_code = -EINVAL; + goto free_param_and_exit; + } err_code = legacy_callback(wmi_service_ready_ext_event_id, scn_handle, event, data_len);