Netfilter: IRC: Copy nickname to proper address

Fix to copy nickname to address provided by
nickname pointer and avoid overwriting
pointer value.

Change-Id: I8746d8249e807299ae3bec36f6ed9934d8c1628a
Signed-off-by: Paras Singh Jain <parassin@codeaurora.org>
This commit is contained in:
Paras Singh Jain 2015-08-03 18:24:34 +05:30 • committed by Gerrit - the friendly Code Review server
commit a809d69a40

View file

@ -150,10 +150,11 @@ static bool mangle_ip(struct nf_conn *ct,
*do not mangle the DCC Server IP
*/
if (temp->server_ip == tuple->dst.u3.ip &&
(temp->nickname_len == nick_end - nick_start) &&
(memcmp(nick_start, temp->nickname,
temp->nickname_len) == 0))
return false;
(temp->nickname_len == (nick_end - nick_start))) {
if (memcmp(nick_start, temp->nickname,
temp->nickname_len) == 0)
return false;
}
}
return true;
}
@ -191,7 +192,7 @@ static int handle_nickname(struct nf_conn *ct,
kmalloc(i, GFP_ATOMIC);
if (temp->nickname) {
temp->nickname_len = i;
memcpy(&temp->nickname,
memcpy(temp->nickname,
nick_start, temp->nickname_len);
} else {
list_del(&temp->ptr);