From a8ce12744d18561f7eec978d68b6f0c739db8c2f Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Thu, 1 Mar 2018 14:39:10 -0800 Subject: [PATCH] qcacld-3.0: Remove unused hdd_roam_register_tdlssta() param The parameters to function hdd_roam_register_tdlssta() currently includes ucastSig. This "signature" parameter dates back to a previous version of the driver that used signatures to synchronize the data plane with the control plane. However the current version of the driver does not use this parameter, so remove it as part of the plan to completely remove these signatures from throughout the driver. Change-Id: Iee51d79e58501e3e8312c6c7a21b98c1ae6bf268 CRs-Fixed: 2200886 --- core/hdd/inc/wlan_hdd_assoc.h | 6 +++--- core/hdd/src/wlan_hdd_assoc.c | 15 +-------------- core/hdd/src/wlan_hdd_tdls.c | 2 +- 3 files changed, 5 insertions(+), 18 deletions(-) diff --git a/core/hdd/inc/wlan_hdd_assoc.h b/core/hdd/inc/wlan_hdd_assoc.h index 37f0e43f93aa..3bae7581fec8 100644 --- a/core/hdd/inc/wlan_hdd_assoc.h +++ b/core/hdd/inc/wlan_hdd_assoc.h @@ -292,16 +292,16 @@ int hdd_set_csr_auth_type(struct hdd_adapter *adapter, * @adapter: pointer to adapter * @peerMac: pointer to peer MAC address * @staId: station identifier - * @ucastSig: unicast signature + * @qos: Quality of service * - * Construct the staDesc and register with TL the new STA. + * Construct the staDesc and register the new STA with the Data Plane. * This is called as part of ADD_STA in the TDLS setup. * * Return: QDF_STATUS enumeration */ QDF_STATUS hdd_roam_register_tdlssta(struct hdd_adapter *adapter, const uint8_t *peerMac, uint16_t staId, - uint8_t ucastSig, uint8_t qos); + uint8_t qos); #endif QDF_STATUS hdd_roam_deregister_tdlssta(struct hdd_adapter *adapter, diff --git a/core/hdd/src/wlan_hdd_assoc.c b/core/hdd/src/wlan_hdd_assoc.c index 9f4521c93553..41de5d5ea363 100644 --- a/core/hdd/src/wlan_hdd_assoc.c +++ b/core/hdd/src/wlan_hdd_assoc.c @@ -3781,22 +3781,9 @@ roam_roam_connect_status_update_handler(struct hdd_adapter *adapter, } #ifdef FEATURE_WLAN_TDLS -/** - * hdd_roam_register_tdlssta() - register new TDLS station - * @adapter: pointer to adapter - * @peerMac: pointer to peer MAC address - * @staId: station identifier - * @ucastSig: unicast signature - * @qos: QOS capability of TDLS station/link - * - * Construct the staDesc and register with TL the new STA. - * This is called as part of ADD_STA in the TDLS setup. - * - * Return: QDF_STATUS enumeration - */ QDF_STATUS hdd_roam_register_tdlssta(struct hdd_adapter *adapter, const uint8_t *peerMac, uint16_t staId, - uint8_t ucastSig, uint8_t qos) + uint8_t qos) { QDF_STATUS qdf_status = QDF_STATUS_E_FAILURE; struct ol_txrx_desc_type staDesc = { 0 }; diff --git a/core/hdd/src/wlan_hdd_tdls.c b/core/hdd/src/wlan_hdd_tdls.c index d9d60d5c0695..a1f2f0077fcd 100644 --- a/core/hdd/src/wlan_hdd_tdls.c +++ b/core/hdd/src/wlan_hdd_tdls.c @@ -863,7 +863,7 @@ QDF_STATUS hdd_tdls_register_tdls_peer(void *userdata, uint32_t vdev_id, return QDF_STATUS_E_FAILURE; } - return hdd_roam_register_tdlssta(adapter, mac, sta_id, ucastsig, qos); + return hdd_roam_register_tdlssta(adapter, mac, sta_id, qos); } QDF_STATUS hdd_tdls_deregister_tdl_peer(void *userdata,