From a9d252dcc70d4416fa1ac02833b9c71b2cfaa4c4 Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Wed, 11 Apr 2018 15:43:53 -0700 Subject: [PATCH] qcacld-3.0: Kbuild: Remove confusing HAVE_CFG80211 option Currently Kbuild sets a HAVE_CFG80211 flag based upon whether or not CONFIG_CFG80211 is configured. The presence of this flag implies that cfg80211 is optional. However in reality this is a required module, so remove the confusing flag and instead make the underlying code always present. Change-Id: Ia039968cad6f311091e09d4b82805c7bbc5b83f8 CRs-Fixed: 2223856 --- Kbuild | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/Kbuild b/Kbuild index e791830eae6b..5b9ed3e617c3 100644 --- a/Kbuild +++ b/Kbuild @@ -441,16 +441,6 @@ CONFIG_ENABLE_DEBUG_ADDRESS_MARKING := y endif endif -ifeq ($(CONFIG_CFG80211), y) -HAVE_CFG80211 := y -else -ifeq ($(CONFIG_CFG80211),m) -HAVE_CFG80211 := y -else -HAVE_CFG80211 := n -endif -endif - ifeq ($(CONFIG_SLUB_DEBUG_ON), y) CONFIG_FEATURE_UNIT_TEST_SUSPEND := y CONFIG_LEAK_DETECTION := y @@ -486,25 +476,29 @@ HDD_INC := -I$(WLAN_ROOT)/$(HDD_INC_DIR) \ HDD_OBJS := $(HDD_SRC_DIR)/wlan_hdd_assoc.o \ $(HDD_SRC_DIR)/wlan_hdd_cfg.o \ + $(HDD_SRC_DIR)/wlan_hdd_cfg80211.o \ $(HDD_SRC_DIR)/wlan_hdd_data_stall_detection.o \ $(HDD_SRC_DIR)/wlan_hdd_driver_ops.o \ + $(HDD_SRC_DIR)/wlan_hdd_ext_scan.o \ $(HDD_SRC_DIR)/wlan_hdd_ftm.o \ $(HDD_SRC_DIR)/wlan_hdd_hostapd.o \ $(HDD_SRC_DIR)/wlan_hdd_ioctl.o \ $(HDD_SRC_DIR)/wlan_hdd_main.o \ - $(HDD_SRC_DIR)/wlan_hdd_object_manager.o \ $(HDD_SRC_DIR)/wlan_hdd_memdump.o \ + $(HDD_SRC_DIR)/wlan_hdd_object_manager.o \ $(HDD_SRC_DIR)/wlan_hdd_oemdata.o \ + $(HDD_SRC_DIR)/wlan_hdd_p2p.o \ $(HDD_SRC_DIR)/wlan_hdd_packet_filter.o \ $(HDD_SRC_DIR)/wlan_hdd_power.o \ $(HDD_SRC_DIR)/wlan_hdd_regulatory.o \ $(HDD_SRC_DIR)/wlan_hdd_request_manager.o \ $(HDD_SRC_DIR)/wlan_hdd_scan.o \ - $(HDD_SRC_DIR)/wlan_hdd_spectralscan.o \ $(HDD_SRC_DIR)/wlan_hdd_softap_tx_rx.o \ + $(HDD_SRC_DIR)/wlan_hdd_spectralscan.o \ + $(HDD_SRC_DIR)/wlan_hdd_stats.o \ $(HDD_SRC_DIR)/wlan_hdd_sysfs.o \ - $(HDD_SRC_DIR)/wlan_hdd_tx_rx.o \ $(HDD_SRC_DIR)/wlan_hdd_trace.o \ + $(HDD_SRC_DIR)/wlan_hdd_tx_rx.o \ $(HDD_SRC_DIR)/wlan_hdd_wext.o \ $(HDD_SRC_DIR)/wlan_hdd_wmm.o \ $(HDD_SRC_DIR)/wlan_hdd_wowl.o @@ -542,13 +536,6 @@ ifeq ($(CONFIG_IPA_OFFLOAD), y) HDD_OBJS += $(HDD_SRC_DIR)/wlan_hdd_ipa.o endif -ifeq ($(HAVE_CFG80211), y) -HDD_OBJS += $(HDD_SRC_DIR)/wlan_hdd_cfg80211.o \ - $(HDD_SRC_DIR)/wlan_hdd_ext_scan.o \ - $(HDD_SRC_DIR)/wlan_hdd_stats.o \ - $(HDD_SRC_DIR)/wlan_hdd_p2p.o -endif - ifeq ($(CONFIG_QCACLD_FEATURE_NAN), y) HDD_OBJS += $(HDD_SRC_DIR)/wlan_hdd_nan.o endif @@ -2032,14 +2019,12 @@ CDEFINES += \ -DTIMER_MANAGER endif -ifeq ($(HAVE_CFG80211), y) CDEFINES += -DWLAN_FEATURE_P2P CDEFINES += -DWLAN_FEATURE_WFD ifeq ($(CONFIG_QCOM_VOWIFI_11R), y) CDEFINES += -DKERNEL_SUPPORT_11R_CFG80211 CDEFINES += -DUSE_80211_WMMTSPEC_FOR_RIC endif -endif ifeq ($(CONFIG_QCOM_ESE), y) CDEFINES += -DFEATURE_WLAN_ESE