From abd1a7c44cc46f39b3f8f1733e4b7ff939858292 Mon Sep 17 00:00:00 2001 From: Gangadhar Kavalastramath Date: Wed, 4 May 2022 21:21:38 +0530 Subject: [PATCH] qcacld-3.0: Initialize local struct objects Initialize struct cm_roam_values_copy to avoid using uninitialized parameters in wlan_cm_roam_cfg_set_value(). Initialize struct pdev_params to zero to avoid using uninitialized parameters in wmi_unified_pdev_param_send(). Change-Id: I820db09840431487f1756695a0562f8a794f549f CRs-Fixed: 3187194 --- .../components/fw_offload/core/src/wlan_fw_offload_main.c | 4 ++-- .../staging/qcacld-3.0/core/sme/src/csr/csr_neighbor_roam.c | 4 ++-- drivers/staging/qcacld-3.0/core/wma/src/wma_mgmt.c | 2 +- drivers/staging/qcacld-3.0/core/wma/src/wma_power.c | 4 ++-- drivers/staging/qcacld-3.0/core/wma/src/wma_utils.c | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/qcacld-3.0/components/fw_offload/core/src/wlan_fw_offload_main.c b/drivers/staging/qcacld-3.0/components/fw_offload/core/src/wlan_fw_offload_main.c index bc429b87fe7f..bb99a0eedbea 100644 --- a/drivers/staging/qcacld-3.0/components/fw_offload/core/src/wlan_fw_offload_main.c +++ b/drivers/staging/qcacld-3.0/components/fw_offload/core/src/wlan_fw_offload_main.c @@ -739,7 +739,7 @@ QDF_STATUS fwol_set_ilp_config(struct wlan_objmgr_pdev *pdev, uint32_t enable_ilp) { QDF_STATUS status; - struct pdev_params pdev_param; + struct pdev_params pdev_param = {}; pdev_param.param_id = WMI_PDEV_PARAM_PCIE_HW_ILP; pdev_param.param_value = enable_ilp; @@ -755,7 +755,7 @@ QDF_STATUS fwol_configure_hw_assist(struct wlan_objmgr_pdev *pdev, bool disable_hw_assist) { QDF_STATUS status; - struct pdev_params pdev_param; + struct pdev_params pdev_param = {}; pdev_param.param_id = WMI_PDEV_PARAM_DISABLE_HW_ASSIST; pdev_param.param_value = disable_hw_assist; diff --git a/drivers/staging/qcacld-3.0/core/sme/src/csr/csr_neighbor_roam.c b/drivers/staging/qcacld-3.0/core/sme/src/csr/csr_neighbor_roam.c index df8c0cfabee5..e40a9efd179c 100644 --- a/drivers/staging/qcacld-3.0/core/sme/src/csr/csr_neighbor_roam.c +++ b/drivers/staging/qcacld-3.0/core/sme/src/csr/csr_neighbor_roam.c @@ -175,7 +175,7 @@ QDF_STATUS csr_neighbor_roam_update_config(struct mac_context *mac_ctx, tpCsrNeighborRoamControlInfo pNeighborRoamInfo = &mac_ctx->roam.neighborRoamInfo[session_id]; tpCsrNeighborRoamCfgParams cfg_params; - struct cm_roam_values_copy src_cfg; + struct cm_roam_values_copy src_cfg = {}; eCsrNeighborRoamState state; uint8_t old_value; @@ -786,7 +786,7 @@ static void csr_neighbor_roam_info_ctx_init(struct mac_context *mac, { tpCsrNeighborRoamControlInfo ngbr_roam_info = &mac->roam.neighborRoamInfo[session_id]; - struct cm_roam_values_copy src_cfg; + struct cm_roam_values_copy src_cfg = {}; struct csr_roam_session *session = &mac->roam.roamSession[session_id]; int init_ft_flag = false; struct wlan_objmgr_vdev *vdev = NULL; diff --git a/drivers/staging/qcacld-3.0/core/wma/src/wma_mgmt.c b/drivers/staging/qcacld-3.0/core/wma/src/wma_mgmt.c index e6136508c682..3c7e6c9105e0 100644 --- a/drivers/staging/qcacld-3.0/core/wma/src/wma_mgmt.c +++ b/drivers/staging/qcacld-3.0/core/wma/src/wma_mgmt.c @@ -2815,7 +2815,7 @@ QDF_STATUS wma_set_cts2self_for_p2p_go(void *wma_handle, { int32_t ret; tp_wma_handle wma = (tp_wma_handle)wma_handle; - struct pdev_params pdevparam; + struct pdev_params pdevparam = {}; pdevparam.param_id = WMI_PDEV_PARAM_CTS2SELF_FOR_P2P_GO_CONFIG; pdevparam.param_value = cts2self_for_p2p_go; diff --git a/drivers/staging/qcacld-3.0/core/wma/src/wma_power.c b/drivers/staging/qcacld-3.0/core/wma/src/wma_power.c index 6c8004735a15..4fdc73e85179 100644 --- a/drivers/staging/qcacld-3.0/core/wma/src/wma_power.c +++ b/drivers/staging/qcacld-3.0/core/wma/src/wma_power.c @@ -1090,7 +1090,7 @@ QDF_STATUS wma_process_tx_power_limits(WMA_HANDLE handle, int32_t ret = 0; uint32_t txpower_params2g = 0; uint32_t txpower_params5g = 0; - struct pdev_params pdevparam; + struct pdev_params pdevparam = {}; if (!wma || !wma->wmi_handle) { wma_err("WMA is closed, can not issue tx power limit"); @@ -1455,7 +1455,7 @@ QDF_STATUS wma_set_idle_ps_config(void *wma_ptr, uint32_t idle_ps) { int32_t ret; tp_wma_handle wma = (tp_wma_handle) wma_ptr; - struct pdev_params pdevparam; + struct pdev_params pdevparam = {}; wma_debug("WMA Set Idle Ps Config [1:set 0:clear] val %d", idle_ps); diff --git a/drivers/staging/qcacld-3.0/core/wma/src/wma_utils.c b/drivers/staging/qcacld-3.0/core/wma/src/wma_utils.c index f20151facbbe..a8469e867e05 100644 --- a/drivers/staging/qcacld-3.0/core/wma/src/wma_utils.c +++ b/drivers/staging/qcacld-3.0/core/wma/src/wma_utils.c @@ -4001,7 +4001,7 @@ QDF_STATUS wma_set_vc_mode_config(void *wma_handle, { int32_t ret; tp_wma_handle wma = (tp_wma_handle)wma_handle; - struct pdev_params pdevparam; + struct pdev_params pdevparam = {}; pdevparam.param_id = WMI_PDEV_UPDATE_WDCVS_ALGO; pdevparam.param_value = vc_bitmap;