A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-30 19:51:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

leds: mt6323: Fix an off by one bug in probe

Browse source 
It should be ">= MT6323_MAX_LEDS" instead of ">".  Also "reg" is a u32
so it can't be negative and we can remove the test for negative values.

Fixes: 216ec6cc4c ("leds: Add LED support for MT6323 PMIC")
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Pavel Machek <[email protected]>
Signed-off-by: Jacek Anaszewski <[email protected]>
This commit is contained in:
Dan Carpenter 2017-03-23 13:40:49 +03:00 • committed by Jacek Anaszewski
commit ac57245215
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/leds/leds-mt6323.c
View file

@ -417,7 +417,7 @@ static int mt6323_led_probe(struct platform_device *pdev)
goto put_child_node;
}
if (reg < 0 || reg > MT6323_MAX_LEDS || leds->led[reg]) {
if (reg >= MT6323_MAX_LEDS || leds->led[reg]) {
dev_err(dev, "Invalid led reg %u\n", reg);
ret = -EINVAL;
goto put_child_node;