From 17a9db976dc6812e02bbdc933c19350556db87af Mon Sep 17 00:00:00 2001 From: Deepak Kumar Singh Date: Tue, 2 Feb 2021 19:14:08 +0530 Subject: [PATCH] net: qrtr: fix tx flow memory leak The flow is allocated in qrtr_tx_wait, but not freed when qrtr node is released. (*slot) becomes NULL after radix_tree_iter_delete is called in __qrtr_node_release. The fix is to save (*slot) to a vairable and then free it. This memory leak is catched when kmemleak is enabled in kernel, the report looks like below: unreferenced object 0xffffa0de69e08420 (size 32): comm "kworker/u16:3", pid 176, jiffies 4294918275 (age 82858.876s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 28 84 e0 69 de a0 ff ff ........(..i.... 28 84 e0 69 de a0 ff ff 03 00 00 00 00 00 00 00 (..i............ backtrace: [<00000000e252af0a>] qrtr_node_enqueue+0x38e/0x400 [qrtr] [<000000009cea437f>] qrtr_sendmsg+0x1e0/0x2a0 [qrtr] [<000000008bddbba4>] sock_sendmsg+0x5b/0x60 [<0000000003beb43a>] qmi_send_message.isra.3+0xbe/0x110 [qmi_helpers] [<000000009c9ae7de>] qmi_send_request+0x1c/0x20 [qmi_helpers] Change-Id: If032d223388286557df7e689c2a003705b8f38db Signed-off-by: Carl Huang Signed-off-by: Deepak Kumar Singh --- net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 2e7fb5518ec4..b34393d86dd5 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -370,7 +370,7 @@ static void __qrtr_node_release(struct kref *kref) kfree(waiter); } radix_tree_iter_delete(&node->qrtr_tx_flow, &iter, slot); - kfree(*slot); + kfree(flow); } mutex_unlock(&node->qrtr_tx_lock);