mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 11:11:45 -04:00
drivers/rtc/rtc-max77686.c: fix incorrect return value on error
'ret' was not initialized to error code before returning. While at it also remove some redundant code and cleanup. Signed-off-by: Sachin Kamat <[email protected]> Cc: Chiwoong Byun <[email protected]> Cc: Jonghwa Lee <[email protected]> Cc: Laxman dewangan <[email protected]> Cc: Venu Byravarasu <[email protected]> Cc: Jingoo Han <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
406dc00407
commit
ad819039f1
1 changed files with 4 additions and 4 deletions
|
|
@ -551,17 +551,17 @@ static int max77686_rtc_probe(struct platform_device *pdev)
|
|||
goto err_rtc;
|
||||
}
|
||||
virq = irq_create_mapping(max77686->irq_domain, MAX77686_RTCIRQ_RTCA1);
|
||||
if (!virq)
|
||||
if (!virq) {
|
||||
ret = -ENXIO;
|
||||
goto err_rtc;
|
||||
}
|
||||
info->virq = virq;
|
||||
|
||||
ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
|
||||
max77686_rtc_alarm_irq, 0, "rtc-alarm0", info);
|
||||
if (ret < 0) {
|
||||
if (ret < 0)
|
||||
dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
|
||||
info->virq, ret);
|
||||
goto err_rtc;
|
||||
}
|
||||
|
||||
err_rtc:
|
||||
return ret;
|
||||
|
|
|
|||
Loading…
Reference in a new issue