A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-09 05:39:54 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Set unloading before grabbing lock

Browse source 
In wlan_hdd_pld_remove(), a global mutext is grabbed before setting the
global "unloading" flag. In the case of __hdd_open(), this flag is
checked before also grabbing the same lock. Ultimately this can lead to
deadlocks when other shared locks are involved. As a short-to-medium
term work around, set the unloading flag before waiting for external
threads to exit. After external threads have exited, then grab the lock
to avoid deadlocking with external threads like those invoking
__hdd_open(). Effectively, this does a stop-and-flush on external
threads into the driver before unloading.

Change-Id: Iaaf52d730807abd9a99950970988ec58a1abb87d
CRs-Fixed: 2251271
This commit is contained in:
Dustin Brown 2018-05-30 13:05:22 -07:00 • committed by nshrivas
commit b1c8990ec8
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
core/hdd/src/wlan_hdd_driver_ops.c
View file

@ -471,12 +471,16 @@ static void wlan_hdd_remove(struct device *dev)
if (!cds_wait_for_external_threads_completion(__func__))
hdd_warn("External threads are still active attempting driver unload anyway");
mutex_lock(&hdd_init_deinit_lock);
hdd_start_driver_ops_timer(eHDD_DRV_OP_REMOVE);
if (QDF_IS_EPPING_ENABLED(cds_get_conparam())) {
epping_disable();
epping_close();
} else {
__hdd_wlan_exit();
}
hdd_stop_driver_ops_timer();
mutex_unlock(&hdd_init_deinit_lock);
cds_set_driver_in_bad_state(false);
cds_set_unload_in_progress(false);
@ -1267,13 +1271,9 @@ static void wlan_hdd_pld_remove(struct device *dev,
enum pld_bus_type bus_type)
{
hdd_enter();
mutex_lock(&hdd_init_deinit_lock);
hdd_start_driver_ops_timer(eHDD_DRV_OP_REMOVE);
wlan_hdd_remove(dev);
hdd_stop_driver_ops_timer();
mutex_unlock(&hdd_init_deinit_lock);
hdd_exit();
}