From b45e776c9c577ac095a447a0afbb064109e31cea Mon Sep 17 00:00:00 2001 From: Mangesh Kunchamwar Date: Thu, 22 Oct 2020 14:08:41 +0530 Subject: [PATCH] ASoC: error check for backend index and MCLK src Update proper error checks for backend index and MCLK src ID. Change-Id: I36680f7bae66f95f099d59740c68861c5ee28d86 Signed-off-by: Nirav Khatri Signed-off-by: Mangesh Kunchamwar --- asoc/msm-pcm-routing-v2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/asoc/msm-pcm-routing-v2.c b/asoc/msm-pcm-routing-v2.c index 8ce0feac95fb..bfeffce5ff57 100644 --- a/asoc/msm-pcm-routing-v2.c +++ b/asoc/msm-pcm-routing-v2.c @@ -31232,12 +31232,12 @@ static int msm_routing_put_mclk_src_cfg(struct snd_kcontrol *kcontrol, mclk_src_id = ucontrol->value.integer.value[1]; mclk_freq = ucontrol->value.integer.value[2]; - if (be_idx < 0 && be_idx >= MSM_BACKEND_DAI_MAX) { + if (be_idx < 0 || be_idx >= MSM_BACKEND_DAI_MAX) { pr_err("%s: Invalid be id %d\n", __func__, be_idx); return -EINVAL; } - if (mclk_src_id < MCLK_SRC_INT && mclk_src_id >= MCLK_SRC_MAX) { + if (mclk_src_id < MCLK_SRC_INT || mclk_src_id >= MCLK_SRC_MAX) { pr_err("%s: Invalid MCLK src %d\n", __func__, mclk_src_id); return -EINVAL; }