From 9fcf966dc83c043cfcee4ee5acf9ab5a9a813287 Mon Sep 17 00:00:00 2001 From: Sudheer Papothi Date: Fri, 20 Mar 2020 01:56:47 +0530 Subject: [PATCH] ASoC: wsa883x: Fix size for register access Fix size for soundwire slave register dump in debug mode. Change-Id: I9d2e4a394943cdb0ba2e5ec5208c96b76b0a1292 Signed-off-by: Sudheer Papothi --- asoc/codecs/wsa883x/wsa883x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/asoc/codecs/wsa883x/wsa883x.c b/asoc/codecs/wsa883x/wsa883x.c index 78d5e80382da..7770864bdbc8 100644 --- a/asoc/codecs/wsa883x/wsa883x.c +++ b/asoc/codecs/wsa883x/wsa883x.c @@ -234,9 +234,9 @@ static ssize_t swr_slave_reg_show(struct swr_device *pdev, char __user *ubuf, if (!is_swr_slave_reg_readable(i)) continue; swr_read(pdev, pdev->dev_num, i, ®_val, 1); - len = snprintf(tmp_buf, 25, "0x%.3x: 0x%.2x\n", i, + len = snprintf(tmp_buf, sizeof(tmp_buf), "0x%.3x: 0x%.2x\n", i, (reg_val & 0xFF)); - if ((total + len) >= count - 1) + if (((total + len) >= count - 1) || (len < 0)) break; if (copy_to_user((ubuf + total), tmp_buf, len)) { pr_err("%s: fail to copy reg dump\n", __func__);