From b58138043819a68bed5d0924179ba2b4a76c604a Mon Sep 17 00:00:00 2001 From: Rajeev Kumar Date: Thu, 29 Jun 2017 17:34:57 -0700 Subject: [PATCH] qcacld-3.0: Address excessive logging during PE frame parsing Commit I1054c7df18780469849be55fc4343f09ac502a49 introduced excessive logging because PE is using WARN log level to dump frames. Reduce log level to debug level and remove hexdump log as its not a fatal/error condition. Change-Id: I75052c28c4bafdf36ff5fd8837da172ccce1abf8 CRs-Fixed: 2066381 --- .../mac/src/pe/lim/lim_process_action_frame.c | 18 ++---- .../src/sys/legacy/src/utils/src/parser_api.c | 60 +++++-------------- 2 files changed, 20 insertions(+), 58 deletions(-) diff --git a/core/mac/src/pe/lim/lim_process_action_frame.c b/core/mac/src/pe/lim/lim_process_action_frame.c index ec26b7bda613..b00033360f3e 100644 --- a/core/mac/src/pe/lim/lim_process_action_frame.c +++ b/core/mac/src/pe/lim/lim_process_action_frame.c @@ -384,7 +384,7 @@ lim_process_ext_channel_switch_action_frame(tpAniSirGlobal mac_ctx, qdf_mem_free(ext_channel_switch_frame); return; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking CHANSW Request (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking CHANSW Request (0x%08x, %d bytes):", status, frame_len); } @@ -1251,10 +1251,8 @@ __lim_process_sm_power_save_update(tpAniSirGlobal pMac, uint8_t *pRxPacketInfo, pBody, frameLen); return; } else if (DOT11F_WARNED(nStatus)) { - pe_warn("There were warnings while unpacking a SMPower Save update (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a SMPower Save update (0x%08x, %d bytes):", nStatus, frameLen); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_ERROR, - pBody, frameLen); } pe_debug("Received SM Power save Mode update Frame with PS_Enable: %d" @@ -1327,10 +1325,8 @@ __lim_process_radio_measure_request(tpAniSirGlobal pMac, uint8_t *pRxPacketInfo, pBody, frameLen); goto err; } else if (DOT11F_WARNED(nStatus)) { - pe_warn("There were warnings while unpacking a Radio Measure request (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a Radio Measure request (0x%08x, %d bytes):", nStatus, frameLen); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pBody, frameLen); } /* Call rrm function to handle the request. */ @@ -1369,10 +1365,8 @@ __lim_process_link_measurement_req(tpAniSirGlobal pMac, uint8_t *pRxPacketInfo, pBody, frameLen); return eSIR_FAILURE; } else if (DOT11F_WARNED(nStatus)) { - pe_warn("There were warnings while unpacking a Link Measure request (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a Link Measure request (0x%08x, %d bytes):", nStatus, frameLen); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pBody, frameLen); } /* Call rrm function to handle the request. */ @@ -1418,10 +1412,8 @@ __lim_process_neighbor_report(tpAniSirGlobal pMac, uint8_t *pRxPacketInfo, qdf_mem_free(pFrm); return; } else if (DOT11F_WARNED(nStatus)) { - pe_warn("There were warnings while unpacking a Neighbor report response (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a Neighbor report response (0x%08x, %d bytes):", nStatus, frameLen); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pBody, frameLen); } /* Call rrm function to handle the request. */ rrm_process_neighbor_report_response(pMac, pFrm, psessionEntry); diff --git a/core/mac/src/sys/legacy/src/utils/src/parser_api.c b/core/mac/src/sys/legacy/src/utils/src/parser_api.c index eeb63a9eac50..cb56e14efe53 100644 --- a/core/mac/src/sys/legacy/src/utils/src/parser_api.c +++ b/core/mac/src/sys/legacy/src/utils/src/parser_api.c @@ -2135,10 +2135,8 @@ sir_convert_probe_req_frame2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking a Probe Request (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a Probe Request (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fProbeRequestto' a 'tSirProbeReq'... */ if (!pr.SSID.present) { @@ -2300,10 +2298,8 @@ tSirRetStatus sir_convert_probe_frame2_struct(tpAniSirGlobal pMac, qdf_mem_free(pr); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking a Probe Response (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a Probe Response (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fProbeResponse' to a 'tSirProbeRespBeacon'... */ @@ -2585,10 +2581,8 @@ sir_convert_assoc_req_frame2_struct(tpAniSirGlobal pMac, qdf_mem_free(ar); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking an Assoication Request (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking an Assoication Request (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fAssocRequest' to a 'tSirAssocReq'... */ @@ -2781,10 +2775,8 @@ sir_convert_assoc_resp_frame2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking an Association Response (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking an Association Response (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fAssocResponse' a 'tSirAssocRsp'... */ @@ -3005,10 +2997,8 @@ sir_convert_reassoc_req_frame2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking a Re-association Request (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a Re-association Request (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fReAssocRequest' to a 'tSirAssocReq'... */ @@ -3191,10 +3181,8 @@ sir_beacon_ie_ese_bcn_report(tpAniSirGlobal pMac, qdf_mem_free(pBies); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking Beacon IEs (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking Beacon IEs (0x%08x, %d bytes):", status, nPayload); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pPayload, nPayload); } /* & "transliterate" from a 'tDot11fBeaconIEs' to a 'eseBcnReportMandatoryIe'... */ if (!pBies->SSID.present) { @@ -3473,10 +3461,8 @@ sir_parse_beacon_ie(tpAniSirGlobal pMac, qdf_mem_free(pBies); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking Beacon IEs (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking Beacon IEs (0x%08x, %d bytes):", status, nPayload); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pPayload, nPayload); } /* & "transliterate" from a 'tDot11fBeaconIEs' to a 'tSirProbeRespBeacon'... */ if (!pBies->SSID.present) { @@ -3781,10 +3767,8 @@ sir_convert_beacon_frame2_struct(tpAniSirGlobal pMac, qdf_mem_free(pBeacon); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking Beacon IEs (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking Beacon IEs (0x%08x, %d bytes):", status, nPayload); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pPayload, nPayload); } /* & "transliterate" from a 'tDot11fBeacon' to a 'tSirProbeRespBeacon'... */ /* Timestamp */ @@ -4139,10 +4123,8 @@ sir_convert_auth_frame2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking an Authentication frame (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking an Authentication frame (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fAuthentication' to a 'tSirMacAuthFrameBody'... */ pAuth->authAlgoNumber = auth.AuthAlgo.algo; @@ -4207,10 +4189,8 @@ sir_convert_addts_req2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking an Add TS Request frame (0x%08x,%d bytes):", + pe_debug("There were warnings while unpacking an Add TS Request frame (0x%08x,%d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fAddTSRequest' or a */ /* 'tDot11WMMAddTSRequest' to a 'tSirMacAddtsReqInfo'... */ @@ -4340,10 +4320,8 @@ sir_convert_addts_rsp2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking an Add TS Response frame (0x%08x,%d bytes):", + pe_debug("There were warnings while unpacking an Add TS Response frame (0x%08x,%d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fAddTSResponse' or a */ /* 'tDot11WMMAddTSResponse' to a 'tSirMacAddtsRspInfo'... */ @@ -4508,10 +4486,8 @@ sir_convert_delts_req2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking an Del TS Request frame (0x%08x,%d bytes):", + pe_debug("There were warnings while unpacking an Del TS Request frame (0x%08x,%d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fDelTSResponse' or a */ /* 'tDot11WMMDelTSResponse' to a 'tSirMacDeltsReqInfo'... */ @@ -4566,10 +4542,8 @@ sir_convert_qos_map_configure_frame2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking Qos Map Configure frame (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking Qos Map Configure frame (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } pQosMapSet->present = mapConfigure.QosMapSet.present; convert_qos_mapset_frame(pMac->hHdd, pQosMapSet, &mapConfigure.QosMapSet); @@ -4596,10 +4570,8 @@ sir_convert_tpc_req_frame2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking a TPC Request frame (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a TPC Request frame (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fTPCRequest' to a */ /* 'tSirMacTpcReqActionFrame'... */ @@ -4638,10 +4610,8 @@ sir_convert_meas_req_frame2_struct(tpAniSirGlobal pMac, pFrame, nFrame); return eSIR_FAILURE; } else if (DOT11F_WARNED(status)) { - pe_warn("There were warnings while unpacking a Measurement Request frame (0x%08x, %d bytes):", + pe_debug("There were warnings while unpacking a Measurement Request frame (0x%08x, %d bytes):", status, nFrame); - QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_WARN, - pFrame, nFrame); } /* & "transliterate" from a 'tDot11fMeasurementRequest' to a */ /* 'tpSirMacMeasReqActionFrame'... */