A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-12 07:37:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

arm-smmu: Fix iommu group refcount leak

Browse source 
If a client defines the qcom,iommu-group property, and the iommu group
does not yet exist, of_get_device_group will create a new group with a
refcount of one. The following call to iommu_group_ref_get() increments
the refcount unnecessarily and causes a resource leak.

If a client defines the qcom,iommu-group property, and the iommu group
already exists, modify __bus_lookup_iommu_group() to return with
an additional refcount.

Change-Id: I5c9e62e50737ee4128a591ea2b14a0d47a1be162
Signed-off-by: Patrick Daly <pdaly@codeaurora.org>
This commit is contained in:
Patrick Daly 2021-02-22 13:12:14 -08:00
commit b6ac46db74
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/iommu/arm-smmu.c
View file

@ -3023,7 +3023,6 @@ static int __bus_lookup_iommu_group(struct device *dev, void *priv)
}
data->group = group;
iommu_group_put(group);
return 1;
}
@ -3703,6 +3702,9 @@ static struct iommu_group *arm_smmu_device_group(struct device *dev)
int i, idx;
group = of_get_device_group(dev);
if (group)
goto finish;
for_each_cfg_sme(fwspec, i, idx) {
if (group && smmu->s2crs[idx].group &&
group != smmu->s2crs[idx].group) {
@ -3729,6 +3731,7 @@ static struct iommu_group *arm_smmu_device_group(struct device *dev)
return NULL;
}
finish:
if (smmu->impl && smmu->impl->device_group &&
smmu->impl->device_group(dev, group)) {
iommu_group_put(group);