A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-12 07:37:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

drv8424_mmi: motor overshoot handling

Browse source 
Transition to COMPACT position in sensors driver scenaRiveright cause
the slider going beyond 3.5 degrees threshold failing position
detection and causing motor faulty state enforced. In this case, it
seems better approach to allow the slider to move all the way to
either EXTENDED or PEEK positions to keep internal state machine
intact

Change-Id: I38425d2ab35e67eb49bb059e6fcee3dee07c394f
Signed-off-by: Konstantin Makariev <hcv867@motorola.com>
Reviewed-on: https://gerrit.mot.com/2453110
SME-Granted: SME Approvals Granted
SLTApproved: Slta Waiver
Tested-by: Jira Key
Reviewed-by: Qing Chang <qing@motorola.com>
Submit-Approved: Jira Key
This commit is contained in:
Konstantin Makariev 2022-12-06 15:22:19 -06:00 • committed by Konstantin Makariev
commit b70af6472a
1 changed files with 37 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

46
drivers/misc/drv8424/drv8424.c
View file

@ -958,12 +958,14 @@ static __ref int motor_kthread(void *arg)
if (kthread_should_stop())
break;
if (md->faulting) {
moto_drv8424_cmd_push(md, CMD_FAULT, 0);
atomic_set(&md->status, STATUS_FAULTING);
moto_drv8424_cmd_push(md, CMD_STATUS, 0);
dev_warn(md->dev, "Motor #%d failure reported!!!\n",
irq_to_gpio(atomic_read(&md->fault_irq)) ==
md->mc.ptable[MOTOR_FAULT1_INT] ? 1 : 2);
value = atomic_read(&md->fault_irq);
if (value != 0) {
moto_drv8424_cmd_push(md, CMD_FAULT, 0);
atomic_set(&md->status, STATUS_FAULTING);
moto_drv8424_cmd_push(md, CMD_STATUS, 0);
dev_warn(md->dev, "Motor #%d failure reported!!!\n",
irq_to_gpio(value) == md->mc.ptable[MOTOR_FAULT1_INT] ? 1 : 2);
}
goto show_stats;
}
/* it's safe to call the following functions even if motor was not running */
@ -1325,8 +1327,17 @@ static __ref int detection_kthread(void *arg)
motor_stop(md, true);
}
if (position != POS_UNKNOWN)
if (position != POS_UNKNOWN) {
/*
* In case position was detected while permanent faulty
* state has been set already, we need to drop it as mishap
*/
if (md->faulting) {
md->faulting = false;
dev_warn(md->dev, "Motor faulting state dropped!!!");
}
dev_info(md->dev, "detected position: %s\n", position_labels[position]);
}
LOGD("samples %d; last data: %d %d %d\n", samples,
md->sensor_data[0], md->sensor_data[1], md->sensor_data[2]);
}
@ -1412,11 +1423,28 @@ static void motor_cmd_work(struct work_struct *work)
break;
case CMD_RECOVERY:
/* pos & dest depends on recovery cause */
dest = atomic_read(&md->destination);
md->power_en = 0;
motor_set_motion_params(md,
atomic_read(&md->position),
atomic_read(&md->destination));
atomic_read(&md->position), dest);
if (dest == POS_COMPACT) {
/* Recovery invoked when motor failed to arrive to
* destination. If the destination is COMPACT, there
* is a chance motor will "overshoot" and go beyond
* COMPACT position w/o properly detecting it.
* In this case slider will go all the way up/down
* to its physical limit. So we need to allow
* detecting those.
* Thus setting destination to UNKNOWN to allow
* moto_drv8424_detect_position() scanning for all
* detectable positions
*/
dest = POS_UNKNOWN;
atomic_set(&md->destination, dest);
}
moto_drv8424_set_enable_with_power(md, true);
if (dest == POS_UNKNOWN)
LOGD("Enabled limits in recovery!!!\n");
break;
case CMD_TIMEOUT:
/* We want to be able detecting ANY valid position, so */