A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-29 19:21:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

tmio_mmc: don't clear unhandled pending interrupts

Browse source 
Previously, it was possible for ack_mmc_irqs() to clear pending interrupt
bits in the CTL_STATUS register, even though the interrupt handler had not
been called.  This was because of a race that existed when doing a
read-modify-write sequence on CTL_STATUS.  After the read step in this
sequence, if an interrupt occurred (causing one of the bits in CTL_STATUS
to be set) the write step would inadvertently clear it.

Observed with the TMIO_STAT_RXRDY bit together with CMD53 on AR6002 and
BCM4318 SDIO cards in polled mode.

This patch eliminates this race by only writing to CTL_STATUS and clearing
the interrupts that were passed as an argument to ack_mmc_irqs()."

[[email protected]: rewrote changelog]
Signed-off-by: Yusuke Goda <[email protected]>
Acked-by: Magnus Damm <[email protected]>"
Tested-by: Arnd Hannemann <[email protected]>"
Acked-by: Ian Molton <[email protected]>
Cc: Matt Fleming <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Cc: Paul Mundt <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
Yusuke Goda 2010-09-09 16:37:39 -07:00 • committed by Linus Torvalds
commit b78d6c5f51
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/mmc/host/tmio_mmc.h
View file

@ -82,10 +82,7 @@
#define ack_mmc_irqs(host, i) \
do { \
u32 mask;\
mask = sd_ctrl_read32((host), CTL_STATUS); \
mask &= ~((i) & TMIO_MASK_IRQ); \
sd_ctrl_write32((host), CTL_STATUS, mask); \
sd_ctrl_write32((host), CTL_STATUS, ~(i)); \
} while (0)