[PATCH] Char: tty_wakeup cleanup

tty_wakeup cleanup

- remove wake_up_interruptible(&tty->write_wait) surrounding
  tty_wakup(tty);
- substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty);

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Alan Cox <[email protected]>
Acked-by: Tilman Schmidt <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
Jiri Slaby 2007-02-10 01:44:55 -08:00 • committed by Linus Torvalds
commit b963a8441c
24 changed files with 23 additions and 121 deletions

View file

@ -616,15 +616,7 @@ static void digi_wakeup_write_lock(struct work_struct *work)
static void digi_wakeup_write( struct usb_serial_port *port )
{
struct tty_struct *tty = port->tty;
/* wake up port processes */
wake_up_interruptible( &port->write_wait );
/* wake up line discipline */
tty_wakeup(tty);
tty_wakeup(port->tty);
}

View file

@ -182,13 +182,8 @@ static void keyspan_pda_wakeup_write(struct work_struct *work)
struct keyspan_pda_private *priv =
container_of(work, struct keyspan_pda_private, wakeup_work);
struct usb_serial_port *port = priv->port;
struct tty_struct *tty = port->tty;
/* wake up port processes */
wake_up_interruptible( &port->write_wait );
/* wake up line discipline */
tty_wakeup(tty);
tty_wakeup(port->tty);
}
static void keyspan_pda_request_unthrottle(struct work_struct *work)

View file

@ -269,18 +269,8 @@ static void mos7720_bulk_out_data_callback(struct urb *urb)
tty = mos7720_port->port->tty;
if (tty && mos7720_port->open) {
/* let the tty driver wakeup if it has a special *
* write_wakeup function */
if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
tty->ldisc.write_wakeup)
(tty->ldisc.write_wakeup)(tty);
/* tell the tty driver that something has changed */
wake_up_interruptible(&tty->write_wait);
}
/* schedule_work(&mos7720_port->port->work); */
if (tty && mos7720_port->open)
tty_wakeup(tty);
}
/*

View file

@ -755,18 +755,8 @@ static void mos7840_bulk_out_data_callback(struct urb *urb)
tty = mos7840_port->port->tty;
if (tty && mos7840_port->open) {
/* let the tty driver wakeup if it has a special *
* write_wakeup function */
if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP))
&& tty->ldisc.write_wakeup) {
(tty->ldisc.write_wakeup) (tty);
}
/* tell the tty driver that something has changed */
wake_up_interruptible(&tty->write_wait);
}
if (tty && mos7840_port->open)
tty_wakeup(tty);
}