mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-28 02:32:09 -04:00
md: protect against crash upon fsync on ro array
If an fsync occurs on a read-only array, we need to send a completion for the IO and may not increment the active IO count. Otherwise, we hit a bug trace and can't stop the MD array anymore. By advice of Christoph Hellwig we return success upon a flush request but we return -EROFS for other writes. We detect flush requests by checking if the bio has zero sectors. This patch is suitable to any -stable kernel to which it applies. Cc: Christoph Hellwig <[email protected]> Cc: Ben Hutchings <[email protected]> Cc: NeilBrown <[email protected]> Cc: [email protected] Signed-off-by: Sebastian Riemer <[email protected]> Reported-by: Ben Hutchings <[email protected]> Acked-by: Paul Menzel <[email protected]> Signed-off-by: NeilBrown <[email protected]>
This commit is contained in:
parent
19f949f525
commit
bbfa57c0f2
1 changed files with 4 additions and 0 deletions
|
|
@ -307,6 +307,10 @@ static void md_make_request(struct request_queue *q, struct bio *bio)
|
|||
bio_io_error(bio);
|
||||
return;
|
||||
}
|
||||
if (mddev->ro == 1 && unlikely(rw == WRITE)) {
|
||||
bio_endio(bio, bio_sectors(bio) == 0 ? 0 : -EROFS);
|
||||
return;
|
||||
}
|
||||
smp_rmb(); /* Ensure implications of 'active' are visible */
|
||||
rcu_read_lock();
|
||||
if (mddev->suspended) {
|
||||
|
|
|
|||
Loading…
Reference in a new issue