From bc4779617830ed8a4d0eba9e5db6173c5db974c7 Mon Sep 17 00:00:00 2001 From: Vivek Aknurwar Date: Fri, 29 May 2020 18:14:38 -0700 Subject: [PATCH] clk: qcom: clk-debug: Fix possible NULL dereference in _mux_get_parent Fix possible NULL dereference in retrieving clk parent name. Change-Id: Ic4dbc6632f00365ea127042c0f3bd9b66a243ec6 Signed-off-by: Vivek Aknurwar --- drivers/clk/qcom/clk-debug.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/clk-debug.c b/drivers/clk/qcom/clk-debug.c index 70afd99ed217..b27fe0b488e1 100644 --- a/drivers/clk/qcom/clk-debug.c +++ b/drivers/clk/qcom/clk-debug.c @@ -146,13 +146,17 @@ static u8 clk_debug_mux_get_parent(struct clk_hw *hw) { int i, num_parents = clk_hw_get_num_parents(hw); struct clk_hw *hw_clk = clk_hw_get_parent(hw); + struct clk_hw *clk_parent; const char *parent; if (!hw_clk) return 0; for (i = 0; i < num_parents; i++) { - parent = clk_hw_get_name(clk_hw_get_parent_by_index(hw, i)); + clk_parent = clk_hw_get_parent_by_index(hw, i); + if (!clk_parent) + return 0; + parent = clk_hw_get_name(clk_parent); if (!strcmp(parent, clk_hw_get_name(hw_clk))) { pr_debug("%s: clock parent - %s, index %d\n", __func__, parent, i);