A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-12 07:37:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Avoid uninitialized timer check in ps timer flush

Browse source 
In some cases, some auto powersave timers are never initialized. Change
sme_ps_timer_flush_sync to avoid checking the timer state of such
uninitialized timers.

Change-Id: I0bccca6835238d1d69c71f39fc0ae5a8eee56d23
CRs-Fixed: 2089350
This commit is contained in:
Dustin Brown 2017-08-10 16:21:28 -07:00 • committed by Anjaneedevi Kapparapu
commit bcb82d5fae
1 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
core/sme/src/common/sme_power_save.c
View file

@ -531,6 +531,7 @@ QDF_STATUS sme_ps_enable_disable(tHalHandle hal_ctx, uint32_t session_id,
QDF_STATUS sme_ps_timer_flush_sync(tHalHandle hal, uint8_t session_id)
{
QDF_STATUS status;
tpAniSirGlobal mac_ctx = PMAC_STRUCT(hal);
struct ps_params *ps_parm;
enum ps_state ps_state;
@ -538,28 +539,27 @@ QDF_STATUS sme_ps_timer_flush_sync(tHalHandle hal, uint8_t session_id)
struct sEnablePsParams *req;
t_wma_handle *wma;
status = sme_enable_sta_ps_check(mac_ctx, session_id);
if (QDF_IS_STATUS_ERROR(status)) {
sme_debug("Power save not allowed for vdev id %d", session_id);
return QDF_STATUS_SUCCESS;
}
ps_parm = &mac_ctx->sme.ps_global_info.ps_params[session_id];
tstate = qdf_mc_timer_get_current_state(&ps_parm->auto_ps_enable_timer);
if (tstate != QDF_TIMER_STATE_RUNNING)
return QDF_STATUS_SUCCESS;
if (QDF_STATUS_SUCCESS != sme_enable_sta_ps_check(mac_ctx,
session_id)) {
sme_debug("Power save not allowed for vdev id %d", session_id);
qdf_mc_timer_stop(&ps_parm->auto_ps_enable_timer);
return QDF_STATUS_SUCCESS;
}
sme_debug("flushing powersave enable for vdev %u", session_id);
qdf_mc_timer_stop(&ps_parm->auto_ps_enable_timer);
wma = cds_get_context(QDF_MODULE_ID_WMA);
if (!wma) {
sme_err("wma is null");
return QDF_STATUS_E_INVAL;
}
qdf_mc_timer_stop(&ps_parm->auto_ps_enable_timer);
req = qdf_mem_malloc(sizeof(*req));
if (!req) {
sme_err("out of memory");