A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-12 15:49:17 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacmn: Clear lock->lock.dev to NULL after wake lock destroyed

Browse source 
In kernel 5.4, Wake lock API wakeup_source_register requires
"struct device *" parameter, and it can be NULL value. If it is
NULL, the wakeup_source_register will create a "device" node and return
it by wakeup_source struct.
In qcacld driver, the qdf_wake_lock_create will save the "wakeup_source"
to cld's private struct qdf_wake_lock->lock.
When the cld driver destroy os wake lock by wakeup_source_unregister,
"dev" will also be invalid in kernel, we need to clear the "dev"
field in local copy of wakeup_source in qdf_wake_lock->lock.
This will fix the potential reuse of qdf_wake_lock->lock.dev after it has
been destroyed.

Change-Id: I1de6e95c64b35929bef8be2cdeeb86422bc38515
CRs-Fixed: 2634032
This commit is contained in:
Liangwei Dong 2020-03-03 17:05:03 +08:00 • committed by nshrivas
commit bdd5fcef82
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
qdf/linux/src/qdf_lock.c
View file

@ -268,6 +268,7 @@ qdf_export_symbol(qdf_wake_lock_name);
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 4, 0))
QDF_STATUS qdf_wake_lock_create(qdf_wake_lock_t *lock, const char *name)
{
qdf_mem_zero(lock, sizeof(*lock));
lock->priv = wakeup_source_register(lock->lock.dev, name);
if (!(lock->priv)) {
QDF_BUG(0);