From 27ca1ceb9263aa9f10870ca670af1c983c21e448 Mon Sep 17 00:00:00 2001 From: Subbaraman Narayanamurthy Date: Fri, 7 Aug 2020 16:31:03 -0700 Subject: [PATCH] leds: qti-flash: Fix error logging in qti_flash_led_symmetry_config() If symmetry is enabled and user sets the brightness on switch device directly without setting brightness on flash or torch devices, then an error log is printed. Fix it. Change-Id: I10cc9e3143173fb4ea9dad0ed078fde3594b6e54 Signed-off-by: Subbaraman Narayanamurthy --- drivers/leds/leds-qti-flash.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-qti-flash.c b/drivers/leds/leds-qti-flash.c index 9939f4968a80..d64062f20e90 100644 --- a/drivers/leds/leds-qti-flash.c +++ b/drivers/leds/leds-qti-flash.c @@ -569,14 +569,14 @@ static int qti_flash_led_symmetry_config(struct flash_switch_data *snode) } } - if (symmetric_leds > 0 && total_curr_ma > 0) { - per_led_curr_ma = total_curr_ma / symmetric_leds; - } else { - pr_err("Incorrect configuration, symmetric_leds: %d total_curr_ma: %d\n", + if (!symmetric_leds || !total_curr_ma) { + pr_debug("Incorrect configuration, symmetric_leds: %d total_curr_ma: %d\n", symmetric_leds, total_curr_ma); - return -EINVAL; + return 0; } + per_led_curr_ma = total_curr_ma / symmetric_leds; + if (per_led_curr_ma == 0) { pr_warn("per_led_curr_ma cannot be 0\n"); return 0;