mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 11:11:45 -04:00
rbtree: move some implementation details from rbtree.h to rbtree.c
rbtree users must use the documented APIs to manipulate the tree structure. Low-level helpers to manipulate node colors and parenthood are not part of that API, so move them to lib/rbtree.c [[email protected]: fix jffs2 build issue due to renamed __rb_parent_color field] Signed-off-by: Michel Lespinasse <[email protected]> Cc: Andrea Arcangeli <[email protected]> Acked-by: David Woodhouse <[email protected]> Cc: Rik van Riel <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Daniel Santos <[email protected]> Cc: Jens Axboe <[email protected]> Cc: "Eric W. Biederman" <[email protected]> Signed-off-by: David Woodhouse <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
ea5272f5c9
commit
bf7ad8eeab
3 changed files with 36 additions and 31 deletions
|
|
@ -394,8 +394,11 @@ static int jffs2_add_tn_to_tree(struct jffs2_sb_info *c,
|
|||
}
|
||||
|
||||
/* Trivial function to remove the last node in the tree. Which by definition
|
||||
has no right-hand -- so can be removed just by making its only child (if
|
||||
any) take its place under its parent. */
|
||||
has no right-hand child — so can be removed just by making its left-hand
|
||||
child (if any) take its place under its parent. Since this is only done
|
||||
when we're consuming the whole tree, there's no need to use rb_erase()
|
||||
and let it worry about adjusting colours and balancing the tree. That
|
||||
would just be a waste of time. */
|
||||
static void eat_last(struct rb_root *root, struct rb_node *node)
|
||||
{
|
||||
struct rb_node *parent = rb_parent(node);
|
||||
|
|
@ -412,12 +415,12 @@ static void eat_last(struct rb_root *root, struct rb_node *node)
|
|||
link = &parent->rb_right;
|
||||
|
||||
*link = node->rb_left;
|
||||
/* Colour doesn't matter now. Only the parent pointer. */
|
||||
if (node->rb_left)
|
||||
node->rb_left->rb_parent_color = node->rb_parent_color;
|
||||
node->rb_left->__rb_parent_color = node->__rb_parent_color;
|
||||
}
|
||||
|
||||
/* We put this in reverse order, so we can just use eat_last */
|
||||
/* We put the version tree in reverse order, so we can use the same eat_last()
|
||||
function that we use to consume the tmpnode tree (tn_root). */
|
||||
static void ver_insert(struct rb_root *ver_root, struct jffs2_tmp_dnode_info *tn)
|
||||
{
|
||||
struct rb_node **link = &ver_root->rb_node;
|
||||
|
|
|
|||
Loading…
Reference in a new issue