A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-29 11:11:45 -04:00
Code Issues Projects Releases Packages Wiki Activity

pwm: Check for negative duty-cycle and period

Browse source 
Make sure the duty-cycle and period passed in are not negative. This
should eventually be made implicit by making them unsigned. While at
it, the drivers' .config() implementations can have the equivalent
checks removed.

Signed-off-by: Thierry Reding <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Sachin Kamat <[email protected]>
Cc: Axel Lin <[email protected]>
Cc: Kukjin Kim <[email protected]>
Cc: Jingoo Han <[email protected]>
Cc: Jonghwan Choi <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: "Philip, Avinash" <[email protected]>
Cc: Vaibhav Bedia <[email protected]>
Acked-by: Jingoo Han <[email protected]>
This commit is contained in:
Thierry Reding 2012-09-02 22:13:40 +02:00
commit c2d476a98f
6 changed files with 3 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/pwm/core.c
View file

@ -371,7 +371,7 @@ EXPORT_SYMBOL_GPL(pwm_free);
*/
int pwm_config(struct pwm_device *pwm, int duty_ns, int period_ns)
{
if (!pwm || period_ns == 0 || duty_ns > period_ns)
if (!pwm || duty_ns < 0 || period_ns <= 0 || duty_ns > period_ns)
return -EINVAL;
return pwm->chip->ops->config(pwm->chip, pwm, duty_ns, period_ns);

3
drivers/pwm/pwm-bfin.c
View file

@ -69,9 +69,6 @@ static int bfin_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
unsigned long period, duty;
unsigned long long val;
if (duty_ns < 0 || duty_ns > period_ns)
return -EINVAL;
val = (unsigned long long)get_sclk() * period_ns;
do_div(val, NSEC_PER_SEC);
period = val;

3
drivers/pwm/pwm-pxa.c
View file

@ -70,9 +70,6 @@ static int pxa_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
unsigned long offset;
int rc;
if (period_ns == 0 || duty_ns > period_ns)
return -EINVAL;
offset = pwm->hwpwm ? 0x10 : 0;
c = clk_get_rate(pc->clk);

3
drivers/pwm/pwm-samsung.c
View file

@ -126,9 +126,6 @@ static int s3c_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
if (period_ns > NS_IN_HZ || duty_ns > NS_IN_HZ)
return -ERANGE;
if (duty_ns > period_ns)
return -EINVAL;
if (period_ns == s3c->period_ns &&
duty_ns == s3c->duty_ns)
return 0;

2
drivers/pwm/pwm-tiecap.c
View file

@ -60,7 +60,7 @@ static int ecap_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
unsigned long period_cycles, duty_cycles;
unsigned int reg_val;
if (period_ns < 0 || duty_ns < 0 || period_ns > NSEC_PER_SEC)
if (period_ns > NSEC_PER_SEC)
return -ERANGE;
c = pc->clk_rate;

2
drivers/pwm/pwm-tiehrpwm.c
View file

@ -221,7 +221,7 @@ static int ehrpwm_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
unsigned short ps_divval, tb_divval;
int i, cmp_reg;
if (period_ns < 0 || duty_ns < 0 || period_ns > NSEC_PER_SEC)
if (period_ns > NSEC_PER_SEC)
return -ERANGE;
c = pc->clk_rate;