From 45a6d843aef0569d6ff75ea21afd440598f0003e Mon Sep 17 00:00:00 2001 From: Chris Lew Date: Wed, 7 Oct 2020 16:34:53 -0700 Subject: [PATCH] soc: qcom: smp2p: Log unchanged entries Move log statement so unchanged entries are logged. This increases log spam to the ipc logging buffer but helps catch issues where a smp2p interrupt is missed. Change-Id: I695c324deec13b7a82b4838a1fc91fef594f7f8b Signed-off-by: Chris Lew --- drivers/soc/qcom/smp2p.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index e5267fb029f2..468de2dddfdb 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -254,11 +254,17 @@ static void qcom_smp2p_notify_in(struct qcom_smp2p *smp2p) } smp2p->valid_entries = i; + SMP2P_INFO("%d: smp2p_num:%d in_num:%d\n", + smp2p->remote_pid, smp2p->valid_entries, in->valid_entries); + /* Fire interrupts based on any value changes */ list_for_each_entry(entry, &smp2p->inbound, node) { /* Ignore entries not yet allocated by the remote side */ - if (!entry->value) + if (!entry->value) { + SMP2P_INFO("%d:\t%s: skipping not ready\n", + smp2p->remote_pid, entry->name); continue; + } val = readl(entry->value); @@ -266,13 +272,13 @@ static void qcom_smp2p_notify_in(struct qcom_smp2p *smp2p) entry->last_value = val; status |= *entry->irq_pending; + SMP2P_INFO("%d:\t%s: status:%0lx val:%0x\n", + smp2p->remote_pid, entry->name, status, val); + /* No changes of this entry? */ if (!status) continue; - SMP2P_INFO("%d: %s: status:%0lx val:%0x\n", - smp2p->remote_pid, entry->name, status, val); - for_each_set_bit(i, &status, 32) { if ((val & BIT(i) && test_bit(i, entry->irq_rising)) || (!(val & BIT(i)) && test_bit(i, entry->irq_falling))) {